From b38a39f7a5be827223fbc5b1d3b6ac280b1a2a68 Mon Sep 17 00:00:00 2001 From: Chris Gardner Date: Tue, 15 Aug 2017 22:27:07 +0100 Subject: [PATCH 1/4] Fix PSSA issue --- .../MSFT_xSQLServerScript/MSFT_xSQLServerScript.psm1 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DSCResources/MSFT_xSQLServerScript/MSFT_xSQLServerScript.psm1 b/DSCResources/MSFT_xSQLServerScript/MSFT_xSQLServerScript.psm1 index 01909fa5b..bb31a336d 100644 --- a/DSCResources/MSFT_xSQLServerScript/MSFT_xSQLServerScript.psm1 +++ b/DSCResources/MSFT_xSQLServerScript/MSFT_xSQLServerScript.psm1 @@ -65,7 +65,7 @@ function Get-TargetResource [System.Management.Automation.Credential()] $Credential, - [Parameter(Mandatory = $false)] + [Parameter()] [System.UInt32] $QueryTimeout, @@ -153,7 +153,7 @@ function Set-TargetResource [System.Management.Automation.Credential()] $Credential, - [Parameter(Mandatory = $false)] + [Parameter()] [System.UInt32] $QueryTimeout, @@ -228,7 +228,7 @@ function Test-TargetResource [System.Management.Automation.Credential()] $Credential, - [Parameter(Mandatory = $false)] + [Parameter()] [System.UInt32] $QueryTimeout, @@ -298,7 +298,7 @@ function Invoke-SqlScript [System.Management.Automation.Credential()] $Credential, - [Parameter(Mandatory = $false)] + [Parameter()] [System.UInt32] $QueryTimeout, From e9c0590b7394977d80c915160bd5ec86132e542c Mon Sep 17 00:00:00 2001 From: Chris Gardner Date: Wed, 16 Aug 2017 07:57:40 +0100 Subject: [PATCH 2/4] Updated changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 22d713cd0..a5993d17b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,8 @@ - Added examples (issue #633) - 1-EnableAlwaysOn.ps1 - 2-DisableAlwaysOn.ps1 +- Changes to xSQLServerScript + - - Fixed PS Script Analyser errors ([Issue #728](https://github.com/PowerShell/xSQLServer/issues/728)) - Changes to xSQLServerSetup - Added Swedish localization ([issue #695](https://github.com/PowerShell/xSQLServer/issues/695)). - Now Get-TargetResource correctly returns an array for property ASSysAdminAccounts, From f5691db119e46a61d9b619d6dc0674fce58649c3 Mon Sep 17 00:00:00 2001 From: Chris Gardner Date: Wed, 16 Aug 2017 08:34:57 +0100 Subject: [PATCH 3/4] Fix spelling. --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a5993d17b..5046432fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -52,7 +52,7 @@ - 1-EnableAlwaysOn.ps1 - 2-DisableAlwaysOn.ps1 - Changes to xSQLServerScript - - - Fixed PS Script Analyser errors ([Issue #728](https://github.com/PowerShell/xSQLServer/issues/728)) + - - Fixed PS Script Analyzer errors ([Issue #728](https://github.com/PowerShell/xSQLServer/issues/728)) - Changes to xSQLServerSetup - Added Swedish localization ([issue #695](https://github.com/PowerShell/xSQLServer/issues/695)). - Now Get-TargetResource correctly returns an array for property ASSysAdminAccounts, From 8a06b0eaa93b593abea333b32f404683be54eca9 Mon Sep 17 00:00:00 2001 From: Chris Gardner Date: Wed, 16 Aug 2017 08:41:57 +0100 Subject: [PATCH 4/4] Fix changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5046432fc..0364252a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -52,7 +52,7 @@ - 1-EnableAlwaysOn.ps1 - 2-DisableAlwaysOn.ps1 - Changes to xSQLServerScript - - - Fixed PS Script Analyzer errors ([Issue #728](https://github.com/PowerShell/xSQLServer/issues/728)) + - Fixed PS Script Analyzer errors ([issue #728](https://github.com/PowerShell/xSQLServer/issues/728)) - Changes to xSQLServerSetup - Added Swedish localization ([issue #695](https://github.com/PowerShell/xSQLServer/issues/695)). - Now Get-TargetResource correctly returns an array for property ASSysAdminAccounts,