From 1c4ab9e2fce8dd4f22ef86cc8c4bcb970735b39d Mon Sep 17 00:00:00 2001 From: Matthias Fischer Date: Thu, 1 Aug 2024 14:42:50 +0200 Subject: [PATCH] fix(exception-handling): [#841] remove obsolete todos --- .../tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java | 2 +- .../ess/service/InvestigationJobProcessingEventListener.java | 2 +- .../eclipse/tractusx/irs/edc/client/EdcCallbackController.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java index d29b644942..8f8b4cb608 100644 --- a/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java +++ b/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java @@ -122,7 +122,7 @@ private SubmodelDescriptor getSubmodel(final EdcSubmodelFacade submodelFacade, throw new EdcClientException( String.format("Called %s connectorEndpoints but did not get any submodels. Connectors: '%s'", - connectorEndpoints.size(), String.join(", ", connectorEndpoints))); // TODO (mfischer) + connectorEndpoints.size(), String.join(", ", connectorEndpoints))); } } diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/InvestigationJobProcessingEventListener.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/InvestigationJobProcessingEventListener.java index 44779bd451..17742207c1 100644 --- a/irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/InvestigationJobProcessingEventListener.java +++ b/irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/InvestigationJobProcessingEventListener.java @@ -203,7 +203,7 @@ private void sendNotifications(final Jobs completedJob, final BpnInvestigationJo investigationJobUpdate.withUnansweredNotifications(Collections.singletonList(new Notification(notificationId, bpn))); } catch (final EdcClientException e) { log.error("Exception during sending EDC notification.", e); - investigationJobUpdate.update(completedJob, SupplyChainImpacted.UNKNOWN); // TODO (mfischer) ??? + investigationJobUpdate.update(completedJob, SupplyChainImpacted.UNKNOWN); } }); }); diff --git a/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java b/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java index 2671384e68..a7571b7ef9 100644 --- a/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java +++ b/irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcCallbackController.java @@ -70,7 +70,7 @@ public void receiveEdcCallback(final @RequestBody String endpointDataReferenceCa final String contractId = endpointDataReference.getContractId(); storeEdr(contractId, endpointDataReference); } catch (EdcClientException e) { - log.error("Could not deserialize Endpoint Data Reference {}", endpointDataReferenceCallback); // TODO (mfischer)??? + log.error("Could not deserialize Endpoint Data Reference {}", endpointDataReferenceCallback); } }