From bb621ffb5bc63497b7a96d5c68075a8337daef4f Mon Sep 17 00:00:00 2001
From: Sebastian Zaremba <1636476+vassyz@users.noreply.github.com>
Date: Tue, 24 Oct 2023 09:24:35 +0100
Subject: [PATCH] Fix the routing associated with work history

When the candidate selected full time education, the work history link
wasn't redirecting to the review page.
---
 .../application_form_presenter.rb             |  4 +-
 .../application_form_presenter_spec.rb        | 49 ++++++++++++++++---
 2 files changed, 44 insertions(+), 9 deletions(-)

diff --git a/app/presenters/candidate_interface/application_form_presenter.rb b/app/presenters/candidate_interface/application_form_presenter.rb
index a45b609a27e..c104889b629 100644
--- a/app/presenters/candidate_interface/application_form_presenter.rb
+++ b/app/presenters/candidate_interface/application_form_presenter.rb
@@ -188,7 +188,9 @@ def work_experience_completed?
     end
 
     def work_experience_path(params = nil)
-      if application_form.application_work_experiences.any? || application_form.work_history_explanation.present?
+      if application_form.application_work_experiences.any? ||
+         application_form.work_history_explanation.present? ||
+         application_form.full_time_education?
         Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_review_path(params)
       else
         Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_path(params)
diff --git a/spec/presenters/candidate_interface/application_form_presenter_spec.rb b/spec/presenters/candidate_interface/application_form_presenter_spec.rb
index 552d5786912..470d70631f9 100644
--- a/spec/presenters/candidate_interface/application_form_presenter_spec.rb
+++ b/spec/presenters/candidate_interface/application_form_presenter_spec.rb
@@ -296,20 +296,53 @@
   end
 
   describe '#work_experience_path' do
-    context 'ApplicationForm#restructured_work_history' do
-      it 'returns the length path if no work experience' do
-        application_form = build(:completed_application_form, work_experiences_count: 0, work_history_explanation: '')
-        presenter = described_class.new(application_form)
+    let(:application_form) do
+      create(
+        :completed_application_form,
+        work_experiences_count:,
+        work_history_explanation:,
+        work_history_status:,
+      )
+    end
+    let(:presenter) { described_class.new(application_form) }
+    let(:work_experiences_count) { 0 }
+    let(:work_history_explanation) { nil }
+    let(:work_history_status) { nil }
 
-        expect(presenter.work_experience_path).to eq(
+    subject(:work_experience_path) { presenter.work_experience_path }
+
+    context 'without work experience' do
+      it 'returns the length path' do
+        expect(work_experience_path).to eq(
           Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_path,
         )
       end
+    end
+
+    context 'with work experience' do
+      let(:work_experiences_count) { 1 }
+
+      it 'returns the review path' do
+        expect(work_experience_path).to eq(
+          Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_review_path,
+        )
+      end
+    end
+
+    context 'with work history explanation' do
+      let(:work_history_explanation) { 'Took time off' }
+
+      it 'returns the review path' do
+        expect(presenter.work_experience_path).to eq(
+          Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_review_path,
+        )
+      end
+    end
 
-      it 'returns the review path if work experience' do
-        application_form = create(:completed_application_form, work_experiences_count: 1, work_history_explanation: '')
-        presenter = described_class.new(application_form)
+    context 'with work history status as full time education' do
+      let(:work_history_status) { 'full_time_education' }
 
+      it 'returns the review path' do
         expect(presenter.work_experience_path).to eq(
           Rails.application.routes.url_helpers.candidate_interface_restructured_work_history_review_path,
         )