From ab4c7314f13494fd693f31b35bd9d314246ed7d9 Mon Sep 17 00:00:00 2001
From: johnhg <johnhg@ucar.edu>
Date: Wed, 15 Sep 2021 10:54:51 -0600
Subject: [PATCH] Feature 1912 missing (#1915)

* Per #1912, update logic of Met2dDataFile::process_data_plane(). Rather than returning bad status for a field of all bad data, print a warning message and continue processing.

* Per #1912, fixing typo in error message that I ran into. Doesn't actually apply to this issue.

* Per #1912, making an unrelated change here to fix up the MODE-Analysis log output. It was reporting (nul) for the number of lines being read/kept. Simplify the log messages to print the correct numbers.
---
 met/src/libcode/vx_analysis_util/mode_job.cc | 33 ++++----------------
 met/src/libcode/vx_data2d/data_class.cc      |  5 ++-
 met/src/tools/other/ioda2nc/ioda2nc.cc       |  2 +-
 3 files changed, 9 insertions(+), 31 deletions(-)

diff --git a/met/src/libcode/vx_analysis_util/mode_job.cc b/met/src/libcode/vx_analysis_util/mode_job.cc
index dea7bee574..077733412a 100644
--- a/met/src/libcode/vx_analysis_util/mode_job.cc
+++ b/met/src/libcode/vx_analysis_util/mode_job.cc
@@ -535,20 +535,6 @@ for (j=0; j<Nfields; ++j)  {
 
 }
 
-/*
-for (j=0; j<ncols; ++j)  {
-
-   m = table.col_width(j);
-
-   memset(junk, 0, sizeof(junk));
-
-   for (k=0; k<m; ++k)  junk[k] = underline_char;
-
-   table.set_entry(1, j, junk);
-
-};
-*/
-
 table.line_up_decimal_points();
 
 table.underline_row(1, underline_char);
@@ -587,7 +573,6 @@ void SummaryJob::do_job(const StringArray & mode_files)
 int j;
 const int Nfields = columns.n_elements();
 const int Nfiles  = mode_files.n_elements();
-ConcatString junk;
 AsciiTable t;
 
 
@@ -621,11 +606,9 @@ for (j=0; j<Nfiles; ++j)  {
 
 }
 
-comma_string(n_lines_read, junk);
-mlog << Debug(2) << "Total mode lines read = " << junk << "\n";
-
-comma_string(n_lines_kept, junk);
-mlog << Debug(2) << "Total mode lines kept = " << junk << "\n";
+mlog << Debug(2)
+     << "Total mode lines read = " << n_lines_read << "\n"
+     << "Total mode lines kept = " << n_lines_kept << "\n";
 
    //
    //  output
@@ -989,7 +972,6 @@ void ByCaseJob::do_job(const StringArray & mode_files)
 
 int j;
 const int Nfiles = mode_files.n_elements();
-ConcatString junk;
 int n_valid_times;
 
 
@@ -1023,7 +1005,6 @@ for (j=0; j<n_valid_times; ++j)  {
 
 }
 
-
    //
    //  loop through the files
    //
@@ -1034,11 +1015,9 @@ for (j=0; j<Nfiles; ++j)  {
 
 }
 
-comma_string(n_lines_read, junk);
-mlog << Debug(2) << "Total mode lines read = " << junk << "\n";
-
-comma_string(n_lines_kept, junk);
-mlog << Debug(2) << "Total mode lines kept = " << junk << "\n";
+mlog << Debug(2)
+     << "Total mode lines read = " << n_lines_read << "\n"
+     << "Total mode lines kept = " << n_lines_kept << "\n";
 
    //
    //  output
diff --git a/met/src/libcode/vx_data2d/data_class.cc b/met/src/libcode/vx_data2d/data_class.cc
index 80ddbf3ef1..c3da14d83f 100644
--- a/met/src/libcode/vx_data2d/data_class.cc
+++ b/met/src/libcode/vx_data2d/data_class.cc
@@ -321,9 +321,8 @@ if ( ! vinfo )  return ( false );
 
 if ( dp.is_all_bad_data() )  {
 
-   mlog << Debug(3) << "No valid data found in input data plane!\n";
-
-   return ( false );
+   mlog << Warning << "\nThe field \"" << vinfo->magic_str()
+        << "\" contains no valid data!\n\n";
 
 }
 
diff --git a/met/src/tools/other/ioda2nc/ioda2nc.cc b/met/src/tools/other/ioda2nc/ioda2nc.cc
index 83b3ae5c81..04c58c0909 100644
--- a/met/src/tools/other/ioda2nc/ioda2nc.cc
+++ b/met/src/tools/other/ioda2nc/ioda2nc.cc
@@ -913,7 +913,7 @@ void write_netcdf_hdr_data() {
    // Check for no messages retained
    if(hdr_cnt <= 0) {
       mlog << Error << method_name << " -> "
-           << "No IODA reocrds retained.  Nothing to write.\n\n";
+           << "No IODA records retained.  Nothing to write.\n\n";
       // Delete the NetCDF file
       remove_temp_file(ncfile);
       exit(1);