Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix reading of upside-down CF-compliant NetCDF Rotated Lat/Lon data #2578

Closed
8 of 22 tasks
JohnHalleyGotway opened this issue Jun 15, 2023 · 1 comment · Fixed by #2595 or #2608
Closed
8 of 22 tasks
Assignees
Labels
MET: Library Code priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jun 15, 2023

Describe the Problem

@mpm-meto sent a sample NetCDF file containing data originally generated by LFRic, but converted to a rotated lat/lon projection and stored in a CF-Compliant NetCDF file. When MET plots it, the data appears upside-down. The country outlines appears in the expected location but the data is plotted upside-down.

The left image is the upside down plot from Plot-Data-Plane. The middle image is the output from ncview. The right image is the plot from panoply:
Screen Shot 2023-06-15 at 9 33 44 AM

Expected Behavior

MET should orient this rotated lat/lon data correctly. Please fix this functionality in both the main_v11.0 branch (for inclusion in MET 11.0.3 bugfix release) and in main_v11.1 (for inclusion in the 11.1.0 release).

To Reproduce

  1. Download this sample data file:
    test_lfric_lam.nc.gz
  2. Run plot_data_plane:
plot_data_plane test_lfric_lam.nc test_lfric_lam.ps 'name="t1p5m"; level="(*,*)";'
  1. Observe the data being upside-down.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working requestor: UK Met Office United Kingdom Met Office alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Library Code priority: high High Priority labels Jun 15, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.3 (bugfix) milestone Jun 15, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Jun 15, 2023
hsoh-u pushed a commit that referenced this issue Jun 29, 2023
@hsoh-u hsoh-u linked a pull request Jun 29, 2023 that will close this issue
15 tasks
@JohnHalleyGotway
Copy link
Collaborator Author

@hsoh-u I see that you fixed this with PR #2595 in main_v11.1. Looks like we'd also like a fix in the main_v11.0 branch. Are you able to port over this fix to the main_v11.0 branch too?

hsoh-u pushed a commit that referenced this issue Jul 12, 2023
@hsoh-u hsoh-u linked a pull request Jul 12, 2023 that will close this issue
15 tasks
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jul 12, 2023
@jprestop jprestop moved this from 🔖 Ready to 👀 In review in MET-11.1.0 Development Jul 12, 2023
@jprestop jprestop moved this from 👀 In review to 🔖 Ready in MET-11.1.0 Development Jul 12, 2023
@jprestop jprestop moved this from 🔖 Ready to 👀 In review in Coordinated METplus-5.0 Support Jul 12, 2023
@jprestop jprestop moved this from 🔖 Ready to ✅ Done in MET-11.1.0 Development Jul 12, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Coordinated METplus-5.0 Support Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Library Code priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Projects
Status: Done
3 participants