Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MET ASCII2NC supported datasets to verification datasets #2568

Open
14 tasks
DanielAdriaansen opened this issue Apr 29, 2024 · 2 comments
Open
14 tasks

Add MET ASCII2NC supported datasets to verification datasets #2568

DanielAdriaansen opened this issue Apr 29, 2024 · 2 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: documentation Documentation issue priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

Describe the Enhancement

When testing the UGRID capability, I noticed that here:
https://met.readthedocs.io/en/develop/Users_Guide/reformat_point.html#ascii2nc-tool

We describe various datasets that are supported by ASCII2NC. However, not all of them are documented here:
https://metplus.readthedocs.io/en/develop/Verification_Datasets/index.html

Notably:

  1. AirNow
  2. NBDC Buoy
  3. IABP
  4. SURFRAD

Seem to be absent from the "Verification Datasets" page. NBDC Buoy data were what I was using. Looking through old PR's, issues, and use cases, I see:

AirNow

dtcenter/MET#2314
dtcenter/MET#2373
(@JohnHalleyGotway and @davidalbo)

NBDC Buoy

dtcenter/MET#2294
#1908
(@j-opatz and @davidalbo)

IABP

dtcenter/MET#2846
(@JohnHalleyGotway and @davidalbo)

SURFRAD

dtcenter/MET#205
(@JohnHalleyGotway)

I'll create stubs in the documentation for each dataset, and coordinate with the above folks to curate the content on the page and/or review the content that I add.

Time Estimate

1 day

Relevant Deadlines

NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: enhancement Improve something that it is currently doing component: documentation Documentation issue priority: low Low Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: NCAR/RAL NCAR Research Applications Laboratory labels Apr 29, 2024
@DanielAdriaansen DanielAdriaansen self-assigned this Apr 29, 2024
@DanielAdriaansen
Copy link
Contributor Author

Should also just do #2448 at the same time as this- touching the same code.

@DanielAdriaansen
Copy link
Contributor Author

DanielAdriaansen commented Apr 29, 2024

Working in branch feature_2568_vx_datasets_update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: documentation Documentation issue priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
Status: 🟢 Ready
Development

No branches or pull requests

2 participants