Compile against upstream librespot. #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses upstream dev branch in favor of Jason's fork. The dev branch merged cleanly into that fork, and there was no diff between the two trees. Fixes dtcooper#670 Fixes dtcooper#669
|
Looks good! Go ahead an yourself to the LICENSE file, and we'll merge! |
dtcooper
approved these changes
Sep 16, 2024
|
I overlooked the fact that I had a previously checked out copy of librespot 0.4.2 in raspotify's directory. Therefore leading me to believe that I compiled against 0.5.0 when in fact I was not. Anyways, the updated PR builds against upstream |
1 task
|
LGTM. Merged and cutting a release. Hopefully it works! :) |
|
Cutting as v0.44.0. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses upstream dev branch in favor of Jason's fork.
The dev branch merged cleanly into that fork, and there was no diff between the two trees.The commit trees for the fork and upstream diverge. Many commits won't merge because of conflicts. Some code seems similar on both sides. I have no idea about the potential breakage for downstream users, but the alternative is to leave it unmaintained. Hopefully everything works fine :-)
Fixes #670
Fixes #669