Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integer::MAX_STR_LEN and use it to tell the compiler about the max buffer size #45

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add Integer::MAX_STR_LEN and use it to tell the compiler about the max buffer size #45

merged 1 commit into from
Nov 20, 2024

Conversation

SUPERCILEX
Copy link

@SUPERCILEX SUPERCILEX commented Nov 20, 2024 •
edited
Loading

Implement the ideas discussed to fix #44

@SUPERCILEX
Copy link
Author

Confirmed that this produces the correct assembly for rustix: https://rust.godbolt.org/z/qj3zoE7b6

cc @sunfishcode

dtolnay
dtolnay approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit e7b5808 into dtolnay:master Nov 20, 2024
10 checks passed
@dtolnay dtolnay mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thoughts on adding a MAX_STR_LEN param to the Integer trait?
2 participants
@SUPERCILEX @dtolnay