Implement binding for list types #643
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables implementing
ToSqlfor types that represent lists. Below example starts working:This code works by inferring inner data type of a list from the first element of the list.
This means below code doesn't work since this method doesn't work for empty lists unfortunately:
There are also a breaking change in
ValueRef::Listso that conversion fromValue::Listis possible. Without this change,ValueRef::Listassumes referee is backed by an Arrow array, whileValue::Listis backed byVec<Value>, preventing a conversion.