Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented May 10, 2023

Task/Issue URL: https://app.asana.com/0/0/1204570461490190/f

Tech Design URL:
CC:

Description:

Device model updates. Refresh device list and fix it when first turning on sync.

Steps to test this PR:

  1. Ensure you can turn on, turn off sync
  2. Rename the device
  3. Add a second device, it should update after max 10 seconds to show the new device

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy changed the title sync update device model / refresh device list / fix device list sync update device model / device list fix / poll for devices May 10, 2023
@brindy brindy requested a review from ayoy May 10, 2023 15:42
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Refreshing works great here :)

@ayoy ayoy assigned brindy and unassigned ayoy May 10, 2023
@brindy brindy merged commit bf7cac9 into develop May 10, 2023
@brindy brindy deleted the brindy/sync-update-device-model branch May 10, 2023 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants