This repository was archived by the owner on Feb 24, 2025. It is now read-only.
sync device connected names #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
6 tasks
ayoy
suggested changes
May 17, 2023
Collaborator
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
Hey, it seems it’s broken on both iOS and macOS when adding a third device. See the comment.
| let knownDevices = Set(self.devices.map { $0.id }) | ||
| let devices = try await syncService.login(recoveryKey, deviceName: device.name, deviceType: device.type) | ||
| mapDevices(devices) | ||
| let syncedDevices = self.devices.filter { !knownDevices.contains($0.id) && !$0.isCurrent } |
Collaborator
There was a problem hiding this comment.
There may be something wrong with this check, but if knownDevices really is a set of all previously known devices, that should all be fine.
Anyway, when adding a third device to sync, both iOS and macOS display either 2 devices or 0 devices in the “Device Synced!” popup. I tried with adding iOS to macOS and vice versa.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 23, 2023
* upstream_develop: sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) Update metadata Fix creating DMG from release workflow (#1200) Unit tests to cover sensitive areas of Burner Window (#1169) [Hackdays] Share via QR Code (#1177) Fix sync connect flow (#1195) Update to BSK adding new remote message image (#1194) Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191)
samsymons
added a commit
that referenced
this pull request
May 27, 2023
* release/1.42.0: (26 commits) Bump version to 1.42.0 (28) Update embedded files Network Protection (#1211) Update BSK with autofill 7.1.0 (#1225) Autofill password generation support for iOS (#1212) Sync Engine with support for syncing bookmarks (#1203) Bump BSK for messaging updates (#1213) add newTab pixel, fire pixels only for new users first time (#1219) Update tds endpoint (#1218) prevent devices from being fetch when sync not visible (#1214) License and contributor guidelines for open-sourcing (#1189) Add a unique Bitwarden decryption failure pixel (#1197) Bump version to 1.41.0 (27) Update embedded files Check that the source and target frame security origins are equal (#1207) Add activation points pixels (#1206) Add Login export links to settings and Autofill 3 dot menu (#1183) sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1204469803916196/f
Tech Design URL:
CC:
Description:
Shows real connected device name.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation