Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jul 20, 2023

Task/Issue URL: https://app.asana.com/0/1203822806345703/1205102591611427/f
Tech Design URL:
CC:

Description:
Adds debug menu option back in

Steps to test this PR:

  1. Sign out of Email Protection (if signed in) and Reset the Email Protection InContext Signup Prompt (Debug menu > Reset Data)
  2. Go to https://fill.dev/form/registration-email and tap the grey Dax icon and select the "Hide your email and block trackers" option from the tooltip
  3. This loads a new tab. Go back to the tab you were on and the Dax icon should be gone
  4. Reset the Email Protection InContext Signup Prompt again refresh the web page
  5. Grey dax icon should be back!

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@amddg44 amddg44 changed the title Add Debug menu option back in for Email Protection InContext reset prompt Add Debug menu option back in for resetting the Email Protection InContext prompt Jul 20, 2023
@amddg44 amddg44 requested a review from SabrinaTardio July 20, 2023 15:18
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amddg44 amddg44 merged commit 768fc7c into develop Jul 24, 2023
@amddg44 amddg44 deleted the anya/reinstate-email-incontext-prompt-reset-debug branch July 24, 2023 13:49
samsymons added a commit that referenced this pull request Jul 28, 2023
# By Dominik Kapusta (7) and others
# Via Sam Symons (2) and others
* develop:
  Modularize debug menu and login items logic #3 (#1397)
  Modularize debug menu and login items logic (#1378)
  Fixes of minor issues with Fire Button after the new logic release (#1395)
  Fire Window (#1357)
  Fix reordering favorites in the last row when it's not fully populated (#1401)
  Close the window when cmd+w is pressed on a pinned tab and there are no regular tabs (#1390)
  update sparkle to 2.4.2 (#1362)
  disable trailing_comma (#1394)
  Add support for per-model Sync Data Providers initialization (#1387)
  update favicon logic to fix gsuite icons (#1380)
  Update minor version by default in code_freeze lane (#1392)
  Upload dSYMs from release builds to S3 for Sentry (#1393)
  Set version to 1.48.2.
  Hide Cards UI on macOS Catalina (#1386)
  Hide Cards UI on macOS Catalina (#1386)
  update shield icon only after navigation ended and tab is selected (#1314)
  Add Debug menu option back in for resetting the Email Protection InContext prompt (#1373)
  Bump version to 1.49.0 (42)
  Update embedded files

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants