Upload dSYMs from release builds to S3 for Sentry #1393
Conversation
There was a problem hiding this comment.
This looks good to me!
The only thought I had is whether we should mark this step as optional using continue-on-error. Obviously we need dSYMs to be added to Sentry, but I was wondering if we shouldn't block the release job if for some reason this step fails, given that we can get the dSYMs from the build artifacts and upload them manually.
That said, because this step runs at the very end, if it failed then everything else would have already succeeded anyway and we would have to fix the dSYM upload manually - so making it non-optional keeps it clear that something went wrong and needs attention. So, let's keep it as-is 👍
(But we can add something to the release template about what to do if everything succeeds but the dSYM upload to S3 fails, which would be needed anyway in case someone needs to do the release locally.)
# By Dominik Kapusta (7) and others # Via Sam Symons (2) and others * develop: Modularize debug menu and login items logic #3 (#1397) Modularize debug menu and login items logic (#1378) Fixes of minor issues with Fire Button after the new logic release (#1395) Fire Window (#1357) Fix reordering favorites in the last row when it's not fully populated (#1401) Close the window when cmd+w is pressed on a pinned tab and there are no regular tabs (#1390) update sparkle to 2.4.2 (#1362) disable trailing_comma (#1394) Add support for per-model Sync Data Providers initialization (#1387) update favicon logic to fix gsuite icons (#1380) Update minor version by default in code_freeze lane (#1392) Upload dSYMs from release builds to S3 for Sentry (#1393) Set version to 1.48.2. Hide Cards UI on macOS Catalina (#1386) Hide Cards UI on macOS Catalina (#1386) update shield icon only after navigation ended and tab is selected (#1314) Add Debug menu option back in for resetting the Email Protection InContext prompt (#1373) Bump version to 1.49.0 (42) Update embedded files # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
2 participants
Task/Issue URL: https://app.asana.com/0/1203301625297703/1204873010712988/f
Description:
For notarized app's release workflows, upload dSYMs zip to a dedicated S3 bucket used by Sentry
to fetch debug symbols.
The workflow step runs only for "release" type builds from branches named
release/*orhotfix/*.Steps to test this PR:
Check out the workflow run I made from
release/dominik/gha-upload-dsym-to-s3branch:https://github.com/duckduckgo/macos-browser/actions/runs/5662293581/job/15341963173
proper Sentry bucket (together with AWS credentials). It's important that its format follows
s3://<bucket_name>/macos-browser/<dsym_zip>pattern.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation