This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fix reordering favorites in the last row when it's not fully populated #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
approved these changes
Jul 27, 2023
Collaborator
SabrinaTardio
left a comment
SabrinaTardio
left a comment
There was a problem hiding this comment.
Works perfectly now!
samsymons
added a commit
that referenced
this pull request
Jul 28, 2023
# By Dominik Kapusta (7) and others # Via Sam Symons (2) and others * develop: Modularize debug menu and login items logic #3 (#1397) Modularize debug menu and login items logic (#1378) Fixes of minor issues with Fire Button after the new logic release (#1395) Fire Window (#1357) Fix reordering favorites in the last row when it's not fully populated (#1401) Close the window when cmd+w is pressed on a pinned tab and there are no regular tabs (#1390) update sparkle to 2.4.2 (#1362) disable trailing_comma (#1394) Add support for per-model Sync Data Providers initialization (#1387) update favicon logic to fix gsuite icons (#1380) Update minor version by default in code_freeze lane (#1392) Upload dSYMs from release builds to S3 for Sentry (#1393) Set version to 1.48.2. Hide Cards UI on macOS Catalina (#1386) Hide Cards UI on macOS Catalina (#1386) update shield icon only after navigation ended and tab is selected (#1314) Add Debug menu option back in for resetting the Email Protection InContext prompt (#1373) Bump version to 1.49.0 (42) Update embedded files # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205124491027651/f
Description:
Fix favorites row count calculation for the drag gesture to include
last favorites row also when it's not fully populated.
Steps to test this PR:
It's easiest to populate and manage favorites by importing favorites from e.g. Safari and then adjusting them in Bookmark Management view.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation