Bye Catalina #1501
Bye Catalina #1501
Conversation
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
LGTM, it looks great @tomasstrba! I've tested it on Catalina and Ventura, all works as expected. Thanks!
| private static let currentOSVersion = ProcessInfo.processInfo.operatingSystemVersion | ||
|
|
||
| // Check if the current macOS version is at least the supported version | ||
| static var isCurrentOsSupported: Bool { |
There was a problem hiding this comment.
Tiny suggestion: maybe we could call this isCurrentOsReceivingUpdates, to make it clear what it's about (cause technically whatever the deployment target is, is supported). I'd also be happy to keep it as is, and just update the comment to Check if the current macOS version is receiving app updates.
There was a problem hiding this comment.
maybe isCurrentOSReceivingUpdates ?
From "Follow case conventions" in the API guidelines
There was a problem hiding this comment.
Good idea! Agree with you 👍
|
@tomasstrba I've just found this while running the app on Catalina in dark mode. Perhaps it's a simple fix, and would be worth having it in, especially for the final Catalina release. Let me know if you're unable to work on it this week and I'll try to fix it myself, maybe tomorrow. Thanks!
|
|
Good catch @ayoy! I'll fix it today/tomorrow |
tomasstrba
force-pushed
the
tom/bye-bye-catalina
branch
from
df53d2f to
cab3f4e
Compare
|
okeeeeej let's go! |
# By Diego Rey Mendez (4) and others # Via Diego Rey Mendez * develop: Fixes the BSK version manually #3 Fixes the BSK version manually #2 Fixes the BSK version manually Fix auth token issues (#1563) Bye Catalina (#1501) exempt apps.facebook.com & standard.co.uk for CTL (#1505) Update Gemfile to use fastlane fork (#1537) PopUp window positioning (#1551) Fix AdClickAttribution Mock causing test failures (#1538) Bump version to 1.54.0 (55) Update embedded files Show privacy dashboard for duckduckgo serp (#1521) Use unencrypted password for deduplicated Credentials objects (#1554) DBP: Add missing selector properties to CCF (#1555) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
3 participants
Task/Issue URL: https://app.asana.com/0/0/1205143041156358/f
CC:
Description:
This PR represents a last build for users of Catalina and first few Big Sur versions (< 11.4).
Steps to test this PR:
On Catalina
2. Verify the About Page (Right Menu -> Settings) and the Feedback Form pop up (Right Menu -> Send Feedback) have an info box about OS not being supported anymore.
3. Verify you get a popup about OS not being supported after manually triggering the update (DuckDuckGo -> Check for Updates...)
Note: Our pop up will be followed by the Sparkle pop up. The case where the current os is not supported anymore is covered by Sparkle too.
4. Make sure Duck Player is not part of the build.
Note 2: You can see Click to Load errors in the Console. They are handled in a separate PR -> #1462
On supported OS
5. Make sure the build behaves as expected and no info about unsupported OS is presented
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation