Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205322007351871/f
BSK PR: duckduckgo/BrowserServicesKit#476

Description:
See BSK PR for description and steps to test

@mallexxx mallexxx mentioned this pull request Aug 24, 2023
@mallexxx mallexxx changed the title Fix AdClickAttributionLogic leaking NavigationResponse completionBlock Fix AdClickAttribution Mock causing test failures Aug 24, 2023
@mallexxx mallexxx removed the request for review from ayoy August 24, 2023 13:42
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 29, 2023
@mallexxx mallexxx merged commit 17c34ff into develop Aug 29, 2023
@mallexxx mallexxx deleted the alex/fix-attribution-callback-leak branch August 29, 2023 04:38
samsymons added a commit that referenced this pull request Aug 30, 2023
# By Diego Rey Mendez (4) and others
# Via Diego Rey Mendez
* develop:
  Fixes the BSK version manually #3
  Fixes the BSK version manually #2
  Fixes the BSK version manually
  Fix auth token issues (#1563)
  Bye Catalina (#1501)
  exempt apps.facebook.com & standard.co.uk for CTL (#1505)
  Update Gemfile to use fastlane fork (#1537)
  PopUp window positioning (#1551)
  Fix AdClickAttribution Mock causing test failures (#1538)
  Bump version to 1.54.0 (55)
  Update embedded files
  Show privacy dashboard for duckduckgo serp (#1521)
  Use unencrypted password for deduplicated Credentials objects (#1554)
  DBP: Add missing selector properties to CCF (#1555)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants