This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Code readability improvements #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a two-way connection between a property that stores data, and a view that displays and changes the data
Contributor
Author
|
@samsymons you are welcome to add yours if you want :) |
samsymons
approved these changes
Nov 2, 2020
Collaborator
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
Nice one @tomasstrba, this looks good to me. This is a nice improvement to readability! 👍
1 task
mallexxx
added a commit
that referenced
this pull request
Feb 13, 2023
* canGoBack, canGoForward RePublished, Tab.publishers refactored * redo redirect(_:NavigationAction, invalidatingBackItemIfNeeded) * tests * don‘t use shared state in tests * fix RELEASE * rollback renaming * drop RePublished * fix header name * [navigation #4] SERP headers navigation responder (#887) * SERP headers handling in SerpHeadersNavigationResponder
mallexxx
added a commit
that referenced
this pull request
Feb 13, 2023
* AdClickAttributionTabExtension+NavigationResponder * fix TabExtension test overrides, adClick extension tests * fix AdClickAttributionTabExtensionTests teardown * cleanup * don‘t use shared state in tests * fix adClick inherited attribution initialization * cleanup * Adjust adClick tests to better match UserScripts/UserContentController behaviour; cleanup * fix RELEASE * remove Swifter dependency * fix file header * [navigation #3+4] canGoBack/GoForward; SERP headers (#885) * canGoBack, canGoForward RePublished, Tab.publishers refactored * redo redirect(_:NavigationAction, invalidatingBackItemIfNeeded) * tests * don‘t use shared state in tests * fix RELEASE * rollback renaming * drop RePublished * fix header name * [navigation #4] SERP headers navigation responder (#887) * SERP headers handling in SerpHeadersNavigationResponder * convert TabTests to custom SchemeHandler
samsymons
pushed a commit
that referenced
this pull request
May 23, 2023
samsymons
pushed a commit
that referenced
this pull request
May 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1204215685631880/f * Adds options to simulate tunnel and controller errors for testing * The status bar menu is now controller through the main app * Moves several files to NetworkProtection and NetworkProtectionUI: * Removes some files submitted by mistake * Removes a copy of NetworkProtectionUI submitted by mistake * Added back an empty test file to NetworkProtectionUITests
diegoreymendez
added a commit
that referenced
this pull request
Jul 27, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205144339578924/f ## Stack: - #1378 - #1389 - #1397 <- This PR ## Description: Addresses some feedback in the base PR: - #1378 (comment) - #1378 (comment) - #1378 (comment) - #1378 (comment) - #1378 (comment) - #1378 (comment) - #1378 (comment)
samsymons
added a commit
that referenced
this pull request
Jul 28, 2023
# By Dominik Kapusta (7) and others # Via Sam Symons (2) and others * develop: Modularize debug menu and login items logic #3 (#1397) Modularize debug menu and login items logic (#1378) Fixes of minor issues with Fire Button after the new logic release (#1395) Fire Window (#1357) Fix reordering favorites in the last row when it's not fully populated (#1401) Close the window when cmd+w is pressed on a pinned tab and there are no regular tabs (#1390) update sparkle to 2.4.2 (#1362) disable trailing_comma (#1394) Add support for per-model Sync Data Providers initialization (#1387) update favicon logic to fix gsuite icons (#1380) Update minor version by default in code_freeze lane (#1392) Upload dSYMs from release builds to S3 for Sentry (#1393) Set version to 1.48.2. Hide Cards UI on macOS Catalina (#1386) Hide Cards UI on macOS Catalina (#1386) update shield icon only after navigation ended and tab is selected (#1314) Add Debug menu option back in for resetting the Email Protection InContext prompt (#1373) Bump version to 1.49.0 (42) Update embedded files # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diegoreymendez
added a commit
that referenced
this pull request
Aug 30, 2023
samsymons
added a commit
that referenced
this pull request
Aug 30, 2023
# By Diego Rey Mendez (4) and others # Via Diego Rey Mendez * develop: Fixes the BSK version manually #3 Fixes the BSK version manually #2 Fixes the BSK version manually Fix auth token issues (#1563) Bye Catalina (#1501) exempt apps.facebook.com & standard.co.uk for CTL (#1505) Update Gemfile to use fastlane fork (#1537) PopUp window positioning (#1551) Fix AdClickAttribution Mock causing test failures (#1538) Bump version to 1.54.0 (55) Update embedded files Show privacy dashboard for duckduckgo serp (#1521) Use unencrypted password for deduplicated Credentials objects (#1554) DBP: Add missing selector properties to CCF (#1555) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
quanganhdo
added a commit
that referenced
this pull request
Apr 19, 2024
Task/Issue URL: https://app.asana.com/0/0/1206942473732464/f Tech Design URL: CC: **Description**: Adds the Data Volume item & reorder the menu items. **Steps to test this PR**: 1. Open the VPN screen on either the status bar or main browser 2. Check if data volume is correct 3. Also, verify the menu item ordering. Open DDG should go last. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
1 task
aataraxiaa
added a commit
that referenced
this pull request
Aug 13, 2024
Task/Issue URL: https://app.asana.com/0/1206488453854252/1207802624568506/f **Description**: The PIR v3 migration can fail at three points: 1. Orphaned Record Cleanup 2. Table Recreation 3. Final Foreign Key Violation Check Currently, we throw an explicit error for #3, which is observable via Pixels. We should also throw explicit errors for #1 and #2. This PR adds these new errors.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: -
Tech Design URL: -
CC: -
Description:
A few code readability improvements I wanted to submit with the latest PR. To avoid a one heavy PR I'm submitting this separately.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template