Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for autofill features #113

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

GioSensation
Copy link
Member

Just adds a couple of disclaimers to avoid false alarms when testing autofill across different platforms.

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation GioSensation requested a review from kzar February 3, 2023 15:59
@GioSensation GioSensation self-assigned this Feb 3, 2023
@@ -20,7 +21,7 @@ <h2>Cross origin iframe</h2>

<style>
iframe {
height: 2em;
height: 4em;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that a) the tooltip sort of shows (it's not completely hidden) and b) it shows that it's cut off in extensions but not on macOS.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Copy link
Collaborator

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GioSensation GioSensation merged commit 5d22371 into main Feb 3, 2023
@GioSensation GioSensation deleted the ema/add-info-on-autofill-test branch February 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants