Expose the ability to generate cursors from records #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @bernardd! |
stevedomin
pushed a commit
that referenced
this pull request
Oct 31, 2018
|
v0.5 is out with this change: https://hex.pm/packages/paginator/0.5.0 |
|
Awesome, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively minor change which exposes the ability to generate cursors for records other than the first/last in a page. You can already do this by calling
Cursor.encode/1, but this provides an interface more consistent with thepaginate/3call (that is, specifying cursor fields as a list of atoms).For some background, I'm working on using this library to provide cursor-based pagination through the GraphQL Relay Connection interface (via https://github.com/absinthe-graphql/absinthe_relay), and that requires the ability to attach a cursor to every item rather than just the first and last ones.