Wrong dependency scope

[satsen]

https://github.com/openjfx/javafx-gradle-plugin?tab=readme-ov-file#5-dependency-scope

FXSkins should not bring runtime JavaFX dependencies into my program

Also, I think ControlsFX should be compileOnly as well. Right now I need to exclude it in my own build.gradle to avoid having ControlsFX in my shaded jar. (Like I suggested on JMetro)

[dukke]

Hmm...

FXSkins won't work if the javafx controls module isn't present since javafx classes from that module are exposed in the public API of FXSkins... seems to me that the correct way is to have them be required?

The same for ControlsFX as FXToggleSwitchSkin constructor receives a ToggleSwitch instance and ToggleSwitch is part of Controlsfx. I'd say that even perhaps ControlsFX dependency needs to be changed to "API".

[satsen]

@dukke

To put controlsfx as "api" means that all users of fxskins will also get controlsfx which doesn't make sense in my opinion. Optional dependencies aren't handled with "api". I know modules handle it but not all projects are modular. And it is supposed to be compileOnly for javafx as well.

Examples:

• MaterialFX https://github.com/palexdev/MaterialFX/blob/a7ae81912f00b7cb224392601772b1b7bc6daa09/materialfx/build.gradle#L37
• Ikonli https://github.com/kordamp/ikonli/blob/d5ab4c973876e6194dbddd893c6f32c6a53b7a90/core/ikonli-javafx/ikonli-javafx.gradle#L21

The link I sent in the first comment says "Native dependencies can be avoided by declaring the dependency configuration as compileOnly.". But you seem to have solved the issue in another way because look here at the POM for 1.0.0 which includes windows native binaries (bad), but the POM for 1.1.0 does not. If you didn't do that intentionally it might be worth to check why it did it incorrectly for 1.0.0 but not 1.1.0.