From 6444751207acaeacb647882b5829819d467546ff Mon Sep 17 00:00:00 2001 From: Kumail Jaffer Date: Fri, 2 Oct 2020 18:59:14 -0400 Subject: [PATCH 1/2] Make isEdgeChromium work for Windows 8 --- src/components/helpers/selectors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/helpers/selectors.js b/src/components/helpers/selectors.js index da33849..46f92d5 100644 --- a/src/components/helpers/selectors.js +++ b/src/components/helpers/selectors.js @@ -15,7 +15,7 @@ const isMobileAndTabletType = () => { }; const isEdgeChromiumType = () => { - if (os.name === OS_TYPES.WINDOWS && os.version === '10') { + if (os.name === OS_TYPES.WINDOWS) { return typeof ua === 'string' && ua.indexOf('Edg/') !== -1; } From 6f5e307451070086668cf5c9afdb0a3dace42ef0 Mon Sep 17 00:00:00 2001 From: Kumail Jaffer Date: Fri, 2 Oct 2020 19:11:23 -0400 Subject: [PATCH 2/2] actually, there are mac and linux versions of edge chromium too --- src/components/helpers/selectors.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/components/helpers/selectors.js b/src/components/helpers/selectors.js index 46f92d5..0e9eb3e 100644 --- a/src/components/helpers/selectors.js +++ b/src/components/helpers/selectors.js @@ -15,11 +15,7 @@ const isMobileAndTabletType = () => { }; const isEdgeChromiumType = () => { - if (os.name === OS_TYPES.WINDOWS) { - return typeof ua === 'string' && ua.indexOf('Edg/') !== -1; - } - - return false; + return typeof ua === 'string' && ua.indexOf('Edg/') !== -1; }; const isSmartTVType = () => device.type === DEVICE_TYPES.SMART_TV;