Skip to content

Commit

Permalink
Feat(CB2-13098): Reword imDescription for IM44 (#220)
Browse files Browse the repository at this point in the history
* feat(cb2-13566): change to im44

* feat(cb2-13098): change id to be unique

* feat(cb2-13098): remove additional info hgv and trl from 44 and white space
  • Loading branch information
Daniel-Searle authored Sep 10, 2024
1 parent f1b61fb commit 00da40b
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 27 deletions.
61 changes: 36 additions & 25 deletions tests/resources/defects.json
Original file line number Diff line number Diff line change
Expand Up @@ -8921,7 +8921,7 @@
"imNumber": 44,
"imDescription": "Oil and Waste Leaks",
"imDescriptionWelsh": "Gollyngiadau Olew a Gwastraff",
"forVehicleType": ["psv", "hgv", "trl"],
"forVehicleType": ["psv"],
"additionalInfo": {
"psv": {
"location": {
Expand All @@ -8934,30 +8934,6 @@
"axleNumber": null
},
"notes": true
},
"hgv": {
"location": {
"vertical": null,
"horizontal": null,
"lateral": null,
"longitudinal": null,
"rowNumber": null,
"seatNumber": null,
"axleNumber": null
},
"notes": true
},
"trl": {
"location": {
"vertical": null,
"horizontal": null,
"lateral": null,
"longitudinal": null,
"rowNumber": null,
"seatNumber": null,
"axleNumber": null
},
"notes": true
}
},
"items": [
Expand Down Expand Up @@ -9024,7 +9000,42 @@
"forVehicleType": ["psv"]
}
]
}
]
},
{
"id": 62,
"imNumber": 44,
"imDescription": "Oil Leaks",
"imDescriptionWelsh": "Olew yn Gollwng",
"forVehicleType": ["hgv", "trl"],
"additionalInfo": {
"hgv": {
"location": {
"vertical": null,
"horizontal": null,
"lateral": null,
"longitudinal": null,
"rowNumber": null,
"seatNumber": null,
"axleNumber": null
},
"notes": true
},
"trl": {
"location": {
"vertical": null,
"horizontal": null,
"lateral": null,
"longitudinal": null,
"rowNumber": null,
"seatNumber": null,
"axleNumber": null
},
"notes": true
}
},
"items": [
{
"itemNumber": 1,
"itemDescription": "Any oil leak which can deposit",
Expand Down
6 changes: 4 additions & 2 deletions tests/unit/services/requiredStandardsService.unitTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ describe("required standards Service", () => {
RequiredStandards,
);

const result = await target.getRequiredStandardsByEUVehicleCategory("test");
const result =
await target.getRequiredStandardsByEUVehicleCategory("test");

expect(mockGetDefectsByEUVehicleCategory).toHaveBeenCalledTimes(1);
expect(result?.normal?.length).toBe(635);
Expand All @@ -283,7 +284,8 @@ describe("required standards Service", () => {
RequiredStandards,
);

const result = await target.getRequiredStandardsByEUVehicleCategory("test");
const result =
await target.getRequiredStandardsByEUVehicleCategory("test");

expect(mockGetDefectsByEUVehicleCategory).toHaveBeenCalledTimes(1);
expect(result?.basic?.length).toBe(96);
Expand Down

0 comments on commit 00da40b

Please sign in to comment.