Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create :html-body field #27

Closed
Cleop opened this issue Dec 18, 2018 · 3 comments
Closed

Create :html-body field #27

Cleop opened this issue Dec 18, 2018 · 3 comments
Assignees
@Cleop
Labels
discuss please-test question Further information is requested

Comments

@Cleop
Copy link
Member

Cleop commented Dec 18, 2018

We need a field for text that allows the use of html for styling but that has been stripped of any harmful scripts that could harm a project.

See: club-soda/club-soda-guide#14 (comment)

The basic_html fn in https://github.com/rrrene/html_sanitize_ex seems appropriate as it strips out everything other than the formatting.
@Cleop Cleop self-assigned this Dec 18, 2018
@Cleop
Copy link
Member Author

Cleop commented Dec 18, 2018

@nelsonic - I saw that you have already discussed sanitisation here: #19 and I wanted to check that you see this field type as useful? and a clear name?

@Cleop Cleop added the question Further information is requested label Dec 18, 2018
Cleop added a commit that referenced this issue Dec 18, 2018
@Cleop
#27 Creates html body field type
5bd91f2
@Cleop Cleop mentioned this issue Dec 18, 2018
Merged
nelsonic added a commit that referenced this issue Dec 18, 2018
@nelsonic
Merge pull request #28 from dwyl/html-body-field-#27
a979abb 
Creates Html body field #27
@nelsonic
Copy link
Member

@Cleop makes sense. 👍

@Cleop Cleop mentioned this issue Jan 3, 2019
Closed
@Cleop
Copy link
Member Author

Cleop commented Feb 19, 2019

Closing as this has now been merged in and can be used

@Cleop Cleop closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cleop Cleop

Labels
discuss please-test question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @Cleop