-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade @mdi/font
to 7.4.47
#1770
base: master
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-05-01 01:35:58.884300090 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-05-01 01:35:59.128300192 +0000
@@ -13,10 +13,10 @@
�[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2 �[39m�[1m�[2m 15.86 kB�[22m�[1m�[22m
�[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2 �[39m�[1m�[2m 15.92 kB�[22m�[1m�[22m
�[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2 �[39m�[1m�[2m 17.37 kB�[22m�[1m�[22m
-�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.woff2 �[39m�[1m�[2m 224.35 kB�[22m�[1m�[22m
-�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.woff �[39m�[1m�[2m 319.31 kB�[22m�[1m�[22m
-�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.ttf �[39m�[1m�[2m 662.93 kB�[22m�[1m�[22m
-�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.eot �[39m�[1m�[2m 663.15 kB�[22m�[1m�[22m
+�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.woff2 �[39m�[1m�[2m 403.22 kB�[22m�[1m�[22m
+�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.woff �[39m�[1m�[2m 587.98 kB�[22m�[1m�[22m
+�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.ttf �[39m�[1m�[2m1,307.66 kB�[22m�[1m�[22m
+�[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.eot �[39m�[1m�[2m1,307.88 kB�[22m�[1m�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mNotFound-hash.css �[39m�[1m�[2m 0.03 kB�[22m�[1m�[22m�[2m │ gzip: 0.05 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mVimeoPlayer-hash.css �[39m�[1m�[2m 0.03 kB�[22m�[1m�[22m�[2m │ gzip: 0.05 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mGoogleDrivePlayer-hash.css �[39m�[1m�[2m 0.11 kB�[22m�[1m�[22m�[2m │ gzip: 0.12 kB�[22m
@@ -25,7 +25,7 @@
�[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css �[39m�[1m�[2m 0.93 kB�[22m�[1m�[22m�[2m │ gzip: 0.39 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 12.25 kB�[22m�[1m�[22m�[2m │ gzip: 2.93 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css �[39m�[1m�[2m 30.56 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 367.61 kB�[22m�[1m�[22m�[2m │ gzip: 58.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 520.39 kB�[22m�[1m�[22m�[2m │ gzip: 81.52 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mpirate-hash.js �[39m�[1m�[2m 0.32 kB�[22m�[1m�[22m�[2m │ gzip: 0.25 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
@@ -36,7 +36,7 @@
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
@@ -45,4 +45,4 @@
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 25.27s�[39m
+�[32m✓ built in 25.34s�[39m |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 04-30-deps_remove_material-design-icons-iconfont_ #1770 +/- ##
====================================================================================
Coverage 62.8452% 62.8452%
====================================================================================
Files 168 168
Lines 24912 24912
Branches 1444 1444
====================================================================================
Hits 15656 15656
Misses 9203 9203
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Passing run #1971 ↗︎
Details:
Review all test suite changes for PR #1770 ↗︎ |
I'm unsure whether or not I actually want to upgrade this -- it increases the css we ship by a decent amount, and the savings regarding serving fonts are unclear.