From 8388bd02875e436bbe8ab26c006edada49a4a5cb Mon Sep 17 00:00:00 2001 From: Thomas Heller Date: Thu, 11 Feb 2021 11:55:51 +0000 Subject: [PATCH] fix(expandable-section): Fixes an issue where toggling the expandable section was triggering a form submission. Fixes APM-283142 --- .../expandable-panel/src/expandable-panel-trigger.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libs/barista-components/expandable-panel/src/expandable-panel-trigger.ts b/libs/barista-components/expandable-panel/src/expandable-panel-trigger.ts index d958d80b4f..9f5b430c0d 100644 --- a/libs/barista-components/expandable-panel/src/expandable-panel-trigger.ts +++ b/libs/barista-components/expandable-panel/src/expandable-panel-trigger.ts @@ -36,7 +36,7 @@ import { DtExpandablePanel } from './expandable-panel'; '[attr.aria-expanded]': 'dtExpandablePanel && dtExpandablePanel.expanded', '[attr.aria-controls]': 'dtExpandablePanel && dtExpandablePanel.id', '[tabindex]': 'dtExpandablePanel && dtExpandablePanel.disabled ? -1 : 0', - '(click)': '_handleClick()', + '(click)': '_handleClick($event)', '(keydown)': '_handleKeydown($event)', }, }) @@ -66,7 +66,9 @@ export class DtExpandablePanelTrigger implements OnDestroy { } /** @internal Handles the trigger's click event. */ - _handleClick(): void { + _handleClick(event: MouseEvent): void { + event.preventDefault(); + event.stopPropagation(); if (this.dtExpandablePanel && !this.dtExpandablePanel.disabled) { this.dtExpandablePanel.toggle(); }