From b5d0136788ecbd5dd36512523126ffe4804dc849 Mon Sep 17 00:00:00 2001 From: rowa-audil Date: Tue, 5 May 2020 11:54:00 +0200 Subject: [PATCH] fix(context-dialog): Remove deprecated aria-label input attribute and makes elementRef mandatory. BREAKING CHANGE: Old attributes do not conform with accessibility standards. --- .../context-dialog/src/context-dialog.ts | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/libs/barista-components/context-dialog/src/context-dialog.ts b/libs/barista-components/context-dialog/src/context-dialog.ts index 2d14d7a8f5..84706fb66c 100644 --- a/libs/barista-components/context-dialog/src/context-dialog.ts +++ b/libs/barista-components/context-dialog/src/context-dialog.ts @@ -147,20 +147,6 @@ export class DtContextDialog extends _DtContextDialogMixinBase /** Aria reference to a label describing the context-dialog. */ @Input('aria-labelledby') ariaLabelledBy: string; - /** - * Aria label of the context-dialog's close button. - * @deprecated `aria-label-close-button` does not conform with accessibility standards. - * Please use `ariaLabelClose` input instead. - * @breaking-change Will be removed in version 7.0.0 - */ - @Input('aria-label-close-button') - get depAriaLabelClose(): string { - return this._ariaLabelClose; - } - set depAriaLabelClose(value: string) { - this._ariaLabelClose = value; - } - /** Aria label of the context-dialog's close button. */ @Input() get ariaLabelClose(): string { @@ -215,11 +201,10 @@ export class DtContextDialog extends _DtContextDialogMixinBase private _viewContainerRef: ViewContainerRef, private _changeDetectorRef: ChangeDetectorRef, private _focusTrapFactory: FocusTrapFactory, + private _elementRef: ElementRef, @Attribute('tabindex') tabIndex: string, // tslint:disable-next-line: no-any @Optional() @Inject(DOCUMENT) private _document: any, - /** @breaking-change: `_elementRef` will be mandatory with version 7.0.0 */ - private _elementRef?: ElementRef, @Optional() @Inject(DT_UI_TEST_CONFIG) private _config?: DtUiTestConfiguration,