Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select collapses when no placeholder is provided #148

Open
certainlyakey opened this issue Jul 27, 2023 · 1 comment
Open

Select collapses when no placeholder is provided #148

certainlyakey opened this issue Jul 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@certainlyakey
Copy link
Contributor

certainlyakey commented Jul 27, 2023

What happened?

With an empty string as a placeholder prop value, cvi-ng-select's width collapses.

Since no placeholder value is provided by default and placeholder is not a required prop, then the bug can be reproduced by simply setting the minimally required amount of props to the component, eg.

<cvi-ng-select [items]="items" labelId="select-label-id" htmlId="select-id"></cvi-ng-select>

This seems to be not an Angular issue however, but rather a styling issue.

Reproduction steps

  1. Go to https://e-gov.github.io/cvi/?path=/story/angular-form-select--default
  2. Clear the placeholder control
  3. Remove the pre-set container width via Dev Tools
  4. Observed: the component collapses becoming too small
  5. Expected: the component retains some reasonable width by default

Screenshot

image

Package

Styles

Version

1.12.0

Reproduction URL

https://e-gov.github.io/cvi/?path=/story/angular-form-select--default

Browser

No response

Browser version

No response

Extra details about your environment

No response

Relevant log output

No response

@certainlyakey certainlyakey added the bug Something isn't working label Jul 27, 2023
@certainlyakey
Copy link
Contributor Author

May be fixed by https://github.com/e-gov/cvi/tree/fix-select-collapse, but merging might wait until #91 is merged to potentially large number of conflicts in select.component.stories.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant