Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Storybook-specific styles to storybook nx lib #84

Open
certainlyakey opened this issue Apr 19, 2023 · 1 comment
Open

Move Storybook-specific styles to storybook nx lib #84

certainlyakey opened this issue Apr 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@certainlyakey
Copy link
Contributor

certainlyakey commented Apr 19, 2023

Summary

Right now some of the styles created specifically for Storybook are loaded even if a consumer app doesn't have anything to do with the CVI library Storybook.

There're not many styles there, but it could become a bigger problem with more Storybook customisations coming.

These two files in main.scss are the ones in question:

@import 'storybook/generic';
@import 'storybook/components/current-component';

These imports should still load in the Storybook, but should not be present in main.scss.

What alternatives have you tried?

No response

Does this feature request involve any updates to the reference design?

No

Implementation details

It would be desirable to retain Sass as a CSS preprocessor when writing styles for Storybook. Maybe this integration could help: https://storybook.js.org/recipes/sass.

It might make sense to remove the CVI CSS variables from the Storybook styles and replace them with hardcoded styles or local CSS variables.

@certainlyakey certainlyakey added the enhancement New feature or request label Apr 19, 2023
@certainlyakey
Copy link
Contributor Author

@ekateriinal is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant