Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cvi-ng-reorderable-list-item's input and output properties #92

Open
ceisipeik opened this issue Apr 24, 2023 · 0 comments
Open

Rename cvi-ng-reorderable-list-item's input and output properties #92

ceisipeik opened this issue Apr 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ceisipeik
Copy link
Contributor

Summary

cvi-ng-reorderable-list-item input and output properties have step-specific names. Common component property names should be generic.

What alternatives have you tried?

No response

Does this feature request involve any updates to the reference design?

No

Implementation details

Property name changes could be something like follows:

setAsPreviousStepButtonVisible -> isPreviousItemButtonVisible
setAsNextStepButtonVisible -> isNextItemButtonVisible

swapStepsEvent -> swapItems or swapped
removeStepEvent -> removeItem or removed
@ceisipeik ceisipeik added the enhancement New feature or request label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ceisipeik