Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pay for used gas #8

Open
mdyring opened this issue Jan 14, 2020 · 1 comment
Open

Only pay for used gas #8

mdyring opened this issue Jan 14, 2020 · 1 comment

Comments

@mdyring
Copy link
Contributor

mdyring commented Jan 14, 2020

Users should only pay for gas consumed on a transaction, not the maximum allowance.

This is to prevent "fat finger" incidents (as seen on Cosmos Hub) and for fairness.

This seems in line with what IRISnet is doing: https://github.com/irisnet/irishub/blob/fdc78914a514ead0fc62d4773dcbae1a31b66fac/app/v1/auth/feeauth.go#L63

@blewater
Copy link
Contributor

blewater commented Jun 4, 2021

These SDK developments are relevant #51 (comment) and we need to consider that the transaction parameter GasWanted (--gas) is equivalent to GasLimit in Ethereum and functions correctly in the SDK.
Sure fees are taken in whole and that's a feature just like in Ethereum, BTC and even more relevant once the Cosmos SDK introduces prioritization cosmos/cosmos-sdk#9348
In any case, once the SDK introduces centralized fee management (per message ideally) cosmos/cosmos-sdk#9072 or we offer that along with the aforementioned Refund middleware we could address this issue.

@blewater blewater removed their assignment Jun 4, 2021
@haasted haasted removed this from the Stargate milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants