Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fpw_template #5336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed fpw_template #5336

wants to merge 1 commit into from

Conversation

Jimmi08
Copy link
Contributor

@Jimmi08 Jimmi08 commented Sep 7, 2024

Motivation and Context

Fix for this look:
image

Description

New suggestion:

image

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

@CaMer0n
Copy link
Member

CaMer0n commented Dec 19, 2024

@Jimmi08 Please resubmit. The template should go in e107_core/templates/fpw_template.php.
I could do it, but I prefer you get the credit in the change log.

@CaMer0n CaMer0n added this to the e107 2.4.0 milestone Dec 19, 2024
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Dec 20, 2024

@Jimmi08 Please resubmit. The template should go in e107_core/templates/fpw_template.php. I could do it, but I prefer you get the credit in the change log.

There are bootstrap 5 classes only, it could break something in core templates folder. I don't need credit in the change log, don't wait for me for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants