Update ForestDB to fix builder bug (#163)

eBay · Jan 19, 2024 · 05836d2 · 05836d2
1 parent 279647e
commit 05836d2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/manifest.sh b/manifest.sh
@@ -1 +1 @@
-FORESTDB_COMMIT="46b8aad1897cab70fe81fc10165139e6d6db30e0"
+FORESTDB_COMMIT="c2a0cf7e708e2a1fb883bca1f2f3d6c3c648812e"
diff --git a/tests/jungle/builder_test.cc b/tests/jungle/builder_test.cc
@@ -333,6 +333,23 @@ int builder_api_test(bool compression) {
         CHK_EQ(val_buf.toString(), value_out.toString());
     }
 
+    // Iteration from the middle of sequence number should work.
+    jungle::Status s;
+    jungle::Iterator itr;
+    CHK_Z( itr.initSN(db, NUM / 2) );
+    uint64_t seqnum_cnt = NUM / 2;
+    do {
+        jungle::Record rec_out;
+        jungle::Record::Holder h_rec_out(rec_out);
+        s = itr.get(rec_out);
+        if (!s.ok()) break;
+
+        CHK_EQ(seqnum_cnt, rec_out.seqNum);
+        seqnum_cnt++;
+    } while (itr.next().ok());
+    CHK_Z( itr.close() );
+    CHK_EQ(NUM + 1, seqnum_cnt);
+
     CHK_Z( jungle::DB::close(db) );
     CHK_Z( jungle::shutdown() );
 

diff --git a/third_party/forestdb b/third_party/forestdb
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		FORESTDB_COMMIT="46b8aad1897cab70fe81fc10165139e6d6db30e0"
		FORESTDB_COMMIT="c2a0cf7e708e2a1fb883bca1f2f3d6c3c648812e"
+42 −22		src/forestdb.cc
+21 −12		src/internal_types.h
+15 −0		tests/functional/fdb_functional_test.cc