Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_unread_count on DataReader [10756] #1804

Merged
merged 6 commits into from
Mar 5, 2021

Conversation

MiguelCompany
Copy link
Member

The old Subscriber API has a get_unread_count method. This PR adds the equivalent on DataReader along with checks for it on the DataReader unit tests.

@MiguelCompany MiguelCompany added this to the v2.3.0 milestone Mar 4, 2021
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
EduPonz previously approved these changes Mar 4, 2021
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@EduPonz EduPonz merged commit 462e4ce into master Mar 5, 2021
@EduPonz EduPonz deleted the feature/datareader-unread-count branch March 5, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants