Refs #6715: Feature/optional log fill attr from profiles [6738] #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also backport this to 1.9.x, which is the branch used in ROS2 ? |
EduPonz
changed the title
EduPonz
changed the title
|
The back port to 1.9.x is here |
MiguelCompany
approved these changes
Oct 25, 2019
|
Build status:
|
MiguelCompany
deleted the
feature/optional_log_fill_attr_from_profiles
branch
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked with ros2/rmw_fastrtps 355 PR. It has been done so that the RMW layer does not show log errors when a profile is not found.
log_errorfor only logging the error when user specifies on member functions:XMLProfileManager::fillParticipantAttributesXMLProfileManager::fillPublisherAttributesXMLProfileManager::fillSubscriberAttributes