Allow overriding the client's domain ID through reference #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Build status:
|
pablogs9
previously approved these changes
Apr 10, 2023
Acuadros95
previously approved these changes
Apr 10, 2023
|
@Acuadros95 please run a Micro XRCE-DDS tests using this contribution |
|
@pablogs9 Tests running on eProsima/Micro-XRCE-DDS#158 |
|
Success here eProsima/Micro-XRCE-DDS#158 (comment), we can S&M into develop |
pablogs9
dismissed stale reviews from Acuadros95 and themself
The base branch was changed.
|
Please @iluetkeb rebase into |
Signed-off-by: Ingo Luetkebohle (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
Signed-off-by: Ingo Luetkebohle (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
|
Build status:
|
pablogs9
approved these changes
Apr 17, 2023
|
@Acuadros95 PTAL and S&M |
Acuadros95
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on micro-ROS/micro-ROS-Agent#182
The way this works is that if you set the domain-id to 255 on the client (an ID which is otherwise outside of the allowed range), it will be overridden by the value specified in the reference.