Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong member order in ObjectInfo type #137

Open
jseldent opened this issue Mar 28, 2022 · 3 comments
Open

Wrong member order in ObjectInfo type #137

jseldent opened this issue Mar 28, 2022 · 3 comments
Milestone

Comments

@jseldent
Copy link

Micro-XRCE-DDS reverses the order of the activity and config members in ObjectInfo. According to the official dds_xrce_types.idl, it should be

    @extensibility(FINAL)
    struct ObjectInfo {
        @optional  ActivityInfoVariant  activity;
        @optional  ObjectVariant        config;
    };

But an actual INFO message looks like
screenshot
which has config first.

@pablogs9
Copy link
Member

Is the dissector also in the wrong order?

@pablogs9 pablogs9 modified the milestone: v3.0.0 Mar 29, 2022
@jseldent
Copy link
Author

Yes. That's how I discovered the bug, because I couldn't properly dissect the INFO message if I didn't swap the order.

@pablogs9
Copy link
Member

We will take this into account in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants