Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency setting is sticky on least significant digit #622

Closed
ikbenkous opened this issue Sep 17, 2023 · 2 comments
Closed

Frequency setting is sticky on least significant digit #622

ikbenkous opened this issue Sep 17, 2023 · 2 comments
Labels
bug Something isn't working ToBeConfirmed Bug reports that needs to be confirmed or reproduced by the development tea.
Milestone

Comments

@ikbenkous
Copy link
Contributor

ikbenkous commented Sep 17, 2023

When adjusting rig frequency, user has to scroll past frequency for the klog frequency to update.

See here after tuning down from 14.350.000 down to 14.349.000:
image
The frequency only updated to 14.349 when I tuned 1 Hz down to 14.348.999.

Additionally: when tuning down in frequency, something like 14.347.001 is interpreted as 14.348.
image

Behavior is inverse for tuning upwards.

Note: flrig correctly shows what my physical radio says.

@ikbenkous
Copy link
Contributor Author

ikbenkous commented Sep 17, 2023

Updating Utilities::isSameFreq()'s comparison (if (fabs(fr1 - fr2) < 0.001)) to a precision smaller than 0.001 solves the problem but introduces the following behavior and issues:

  1. Seems to correctly round frequency to nearest whole kHz.
  2. Issues command to snap radio frequency to nearest whole kHz on transition if not in "read-only" mode.
  3. 13.349.500 is rounded upwards.

Further behavior with internal storage and ADIF exports what have you is untested.

Something like 13.349.500 should probably be rounded downwards to 13.349 since copying the leading digits off your radio is the easiest. Or is there some standard to this?

Anyhow, frequency precision is a must here since I have QSOs with a trailing 500 Hz and hear people even use the nearest 100 Hz on 20 meters.

@ea4k ea4k added bug Something isn't working ToBeConfirmed Bug reports that needs to be confirmed or reproduced by the development tea. labels Sep 23, 2023
@ea4k ea4k added this to the KLog-2.4 milestone Sep 23, 2023
@ikbenkous
Copy link
Contributor Author

Fixed by #626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ToBeConfirmed Bug reports that needs to be confirmed or reproduced by the development tea.
Projects
None yet
Development

No branches or pull requests

2 participants