Fix file creation on SD and SDFS #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The O_CREAT/etc. flags on the Pico are a full 32-bits in size, but the core was generating a flag for SdFat using an 8-bit type, so all the O_CREAT, O_TRUNC, O_APPEND, etc. flags got cut off. Fix the flag size. Fixes #214
schkovich
pushed a commit
to schkovich/arduino-pico
that referenced
this pull request
May 24, 2025
…ower#216) Also fix a few typos
schkovich
pushed a commit
to schkovich/arduino-pico
that referenced
this pull request
May 24, 2025
…ower#216) Also fix a few typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The O_CREAT/etc. flags on the Pico are a full 32-bits in size, but the
core was generating a flag for SdFat using an 8-bit type, so all the
O_CREAT, O_TRUNC, O_APPEND, etc. flags got cut off.
Fix the flag size.
Fixes #214