Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OptionalHeader, OptionalParam #105

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Add OptionalHeader, OptionalParam #105

merged 8 commits into from
Jul 12, 2024

Conversation

earthboundkid
Copy link
Owner

See #99

@earthboundkid earthboundkid marked this pull request as draft February 24, 2024 02:41
@coveralls
Copy link

coveralls commented Feb 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8027928784

Details

  • 0 of 36 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.299%
Totals Coverage Status
Change from base Build 8027588241: 0.3%
Covered Lines: 787
Relevant Lines: 862
💛 - Coveralls

@creativecreature
Copy link

Really exited to get this out! Let me know if I can do anything to help 🙏

@earthboundkid
Copy link
Owner Author

Sorry it's been taking so long. This just keeps slipping to the number two spot in my list of things to do. At this point, it just needs some doc changes. I'll see if I can tackle it tonight.

@creativecreature
Copy link

@earthboundkid No worries. Let me know if I can help!

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9912821804

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.299%
Totals Coverage Status
Change from base Build 8753403139: 0.3%
Covered Lines: 787
Relevant Lines: 862
💛 - Coveralls

@earthboundkid earthboundkid marked this pull request as ready for review July 12, 2024 19:04
@earthboundkid earthboundkid enabled auto-merge (rebase) July 12, 2024 19:15
@earthboundkid earthboundkid merged commit e4d1efd into main Jul 12, 2024
4 checks passed
@earthboundkid earthboundkid deleted the cj/optional branch July 12, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@earthboundkid @coveralls @creativecreature