From 2707ab7cf6f558699bda3edfea35284ec42b9050 Mon Sep 17 00:00:00 2001 From: Bart Oldeman Date: Fri, 2 Jun 2023 12:45:43 +0000 Subject: [PATCH] `make shared` is necessary and sufficient with 0.3.23 + xianyi/OpenBLAS#3983 --- easybuild/easyblocks/o/openblas.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/easybuild/easyblocks/o/openblas.py b/easybuild/easyblocks/o/openblas.py index 9ce5034ba0..996dd280e1 100644 --- a/easybuild/easyblocks/o/openblas.py +++ b/easybuild/easyblocks/o/openblas.py @@ -70,10 +70,13 @@ def build_step(self): """ Custom build step excluding the tests """ # Equivalent to `make all` without the tests - build_parts = ['libs', 'netlib'] - for buildopt in self.cfg['buildopts'].split(): - if 'BUILD_RELAPACK' in buildopt and '1' in buildopt: - build_parts += ['re_lapack'] + build_parts = [] + if LooseVersion(self.version) < LooseVersion('0.3.23'): + build_parts += ['libs', 'netlib'] + for buildopt in self.cfg['buildopts'].split(): + if 'BUILD_RELAPACK' in buildopt and '1' in buildopt: + build_parts += ['re_lapack'] + # just shared is necessary and sufficient with 0.3.23 + xianyi/OpenBLAS#3983 build_parts += ['shared'] # Pass CFLAGS through command line to avoid redefinitions (issue xianyi/OpenBLAS#818)