-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be more careful when getting value of particular easyconfig parameter in PythonBundle
and PythonPackage
easyblock, to avoid trouble with unresolved template values
#3537
Conversation
…asyblock, to avoid trouble with unresolved template values like '%(parallel)s'
… in constructor of Bundle easyblock, to avoid trouble with unresolved template values like '%(builddir)s'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hmm, still seeing trouble with |
…Bundle constructor, to avoid trouble with unresolved templates
…ed in Bundle constructor
…arameter in PythonPackage easyblock, to avoid error due to '%(python)s' template not being resolvable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 2 (2 easyconfigs in total) |
crash for |
fixes the following failures in easyconfigs test suite:
PySide2-5.14.2.3-GCCcore-10.2.0.eb
:jax-0.4.25-gfbf-2023a.eb
andjax-0.4.25-gfbf-2023a-CUDA-12.1.1.eb
:edit: requires:
EasyConfig.expect_resolved_template_values
easybuild-framework#4726