Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fail in new Box-Cox-handling in insight 0.99.0.15 #973

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

strengejacke
Copy link
Member

Fixes #970

@strengejacke strengejacke merged commit 12a043c into main Nov 20, 2024
3 checks passed
@strengejacke strengejacke deleted the strengejacke/issue970 branch November 20, 2024 14:55
@JoakimStefansson
Copy link

JoakimStefansson commented Nov 20, 2024

Should this be available in insight 0.99.0.16?

@strengejacke
Copy link
Member Author

Yes

@JoakimStefansson
Copy link

It doesn't seem to be. Should I open a new issue?

@strengejacke
Copy link
Member Author

Works for me:

library(insight)
packageVersion("insight") # ‘0.99.0.15’
#> [1] '0.99.0.16'

a <- aov(formula = (mpg ^ 1.3 - 1) / 1.3 ~ hp, data = mtcars)
insight::find_transformation(a) # "box-cox" - correct
#> [1] "box-cox"
insight::get_transformation(a) # also has a correct output
#> $transformation
#> function(x) (x^1.3-1) / 1.3
#> <environment: 0x000001af044791c0>
#> 
#> $inverse
#> function(x) exp(log(1 + 1.3 * x) / 1.3)
#> <environment: 0x000001af044791c0>

a <- aov(formula = (mpg ^ -1.3 - 1) / -1.3 ~ hp, data = mtcars)
insight::find_transformation(a)
#> [1] "box-cox"
insight::get_transformation(a)
#> $transformation
#> function(x) (x^-1.3-1) / -1.3
#> <environment: 0x000001af068b0778>
#> 
#> $inverse
#> function(x) exp(log(1 + -1.3 * x) / -1.3)
#> <environment: 0x000001af068b0778>

Try easystats::install_latest(force = TRUE) to update to most recent package versions.

@JoakimStefansson
Copy link

Yes, after the forced update, it also works for me.
I had updated to insight 0.99.0.16 with easystats::install_latest(source="development").

@strengejacke
Copy link
Member Author

source="development", that's the default, you don't need to specify that. But sometimes, if we forget to increase version numbers in a PR, easystats::install_latest() won't install newer versions, because version numbers were the same. force = TRUE always installs from r-universe and does not check version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial fail in new Box-Cox-handling in insight 0.99.0.15
2 participants