Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Reorganise the module #17

Closed
claudiu-cristea opened this issue Jan 22, 2018 · 5 comments · Fixed by #94
Closed

Reorganise the module #17

claudiu-cristea opened this issue Jan 22, 2018 · 5 comments · Fixed by #94

Comments

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Jan 22, 2018

The main thing this module is providing, the most important file, is RdfEntitySparqlStorage and the entity query. If I'm asked what this module does and I have to use only one phrase, I would say:

Provides an entity storage class that allows an arbitrary Drupal content entity to use a SPARQL backend. Period.

Form this perspective the rdf_entity entity type is only a use-case of this module. Given all these, I'm proposing:

  1. The rdf_entity should be moved into a separate sub-module. It can be used directly or only as a good example.
  2. The main module should be renamed. Probably to rdf_storage?
  3. All references to applications that are using this module should be removed.
  4. Fix & Move the webprofiler logic in a submodule to be enabled only on dev environments
@sandervd
Copy link
Contributor

Ow, yes!
Let's come up with a sexy name for this 😃

@claudiu-cristea
Copy link
Contributor Author

Let's come up with a sexy name for this

@sandervd rdf_storage?

@claudiu-cristea
Copy link
Contributor Author

This should include also #14.

@claudiu-cristea
Copy link
Contributor Author

@sandervd As the main functionality of the module is the SPARQL entity storage/query I would go with sparql_entity_storage (or sparql_storage?)

@claudiu-cristea
Copy link
Contributor Author

claudiu-cristea commented Oct 25, 2018

Decided for sparql_entity_storage will keep the history (git filter-branch). rdf_entity will live in a separate project keeping the whole history.

claudiu-cristea added a commit that referenced this issue Dec 11, 2018
claudiu-cristea added a commit that referenced this issue Dec 11, 2018
claudiu-cristea added a commit that referenced this issue Dec 11, 2018
claudiu-cristea added a commit that referenced this issue Dec 11, 2018
@claudiu-cristea claudiu-cristea mentioned this issue May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants