Deploy alpha (test fast-forward worklow) #3088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else the resolver used is not the same in dev and prod build. If you print the pdf when running the frontend in npm run dev, it uses @intlify/core::resolveValue. (https://github.com/intlify/vue-i18n-next/blob/bb2e1770a0344b7d6993e03759cf8ba96d7a6396/packages/core-base/src/resolver.ts#L322) If you print the pdf when running the frontend in npm run preview, it uses @intlify/core::resolveWithKeyValue, which only supports flattened messages with the jsonpath as key. (https://github.com/intlify/vue-i18n-next/blob/bb2e1770a0344b7d6993e03759cf8ba96d7a6396/packages/core-base/src/resolver.ts#L305) Fortunately the resolveValue function is exported and we can set the messageResolver when creating the context. resolveFunction should be registered as MessageResolver when core.esm-browser.js is included, but this does not happen somehow. (https://github.com/intlify/vue-i18n-next/blob/bb2e1770a0344b7d6993e03759cf8ba96d7a6396/packages/core/src/index.ts) This happens in the worker thread and when rendering the pdf in the main thread. closes #3068
Only fast-forward if the comment is exactly '/fast-forward' github.event.issue.pull_request is an empty string if it's a pull request.
chore(deps): lock file maintenance
fix(deps): update dependency vue-i18n to v8.28.0
frontend: get environment.js with the commit hash in the url
And check write access and PR status by ourselves, because the fine grained access token has the permission to merge without the review or checks beeing complete.
|
/fast-forward |
|
The PR mergeable_state needs to be clean, was: blocked |
|
/fast-forward |
|
The PR mergeable_state needs to be clean, was: blocked |
|
When I query the API myself using a new personal API token on my account, I get |
|
The PR mergeable_state needs to be clean, was: blocked |
|
/fast-forward |
|
The PR mergeable_state needs to be clean, was: blocked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.