From c88293e471e864e74e5f1fc59bad3d15a360fb85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:35:59 +0000 Subject: [PATCH 01/34] Add a formatting error in db.copy --- db/db.copy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 5813cb18f35..0d893879831 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,7 +18,7 @@ #include #include -int main(int argc, char **argv) +int main(int argc, char **argv) { int ret; struct Option *from_driver, *from_database, *from_table; From dad53354d77fbe6a8094477914fbcc3e113b84e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:46:15 +0000 Subject: [PATCH 02/34] Revert: CI(clang-format): Temporarily set all permissions to write-all --- .github/workflows/clang-format-check.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 6d896fb1b69..4fe750ec4c6 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -13,14 +13,13 @@ concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: ${{ github.ref_protected != true }} - # permissions: {} - permissions: write-all + permissions: {} jobs: formatting-check: name: Formatting Check runs-on: ubuntu-latest - # permissions: - # pull-requests: write + permissions: + pull-requests: write steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 From b50dc857791beea45738f186e2e11d182ad1ba17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:50:22 +0000 Subject: [PATCH 03/34] CI(clang-format): Use reviewdog/action-suggester to add diff comments --- .github/workflows/clang-format-check.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 4fe750ec4c6..f2c6526cca4 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -50,12 +50,17 @@ echo '${{ steps.verify-changed-files.outputs.changed_files }}' echo '```' } >> "$GITHUB_STEP_SUMMARY" - - uses: parkerbxyz/suggest-changes@f5b10bcbfe35840153c0e823095d260d5abad1f9 # v1.0.0 + - name: 'Suggest' + uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: - comment: | - Please commit the suggested changes from clang-format. + tool_name: clang-format + fail_on_error: true + # - uses: parkerbxyz/suggest-changes@f5b10bcbfe35840153c0e823095d260d5abad1f9 # v1.0.0 + # with: + # comment: | + # Please commit the suggested changes from clang-format. - Suggestions can only be added to lines near lines changed in this PR. + # Suggestions can only be added to lines near lines changed in this PR. - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From 4b91bd5a10fbc81dbf95ec89dd8ee344c58fb18e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Tue, 5 Mar 2024 22:52:03 -0500 Subject: [PATCH 04/34] Update main.c Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- db/db.copy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 0d893879831..5813cb18f35 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,7 +18,7 @@ #include #include -int main(int argc, char **argv) +int main(int argc, char **argv) { int ret; struct Option *from_driver, *from_database, *from_table; From 0a5c5d7c5e5ee3e0de85a200f989c9109b822fb7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:09:11 +0000 Subject: [PATCH 05/34] CI(clang-format): Use reviewdog/action-suggester to add code suggestions --- .github/workflows/clang-format-check.yml | 113 +++++++++-------------- 1 file changed, 43 insertions(+), 70 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index f2c6526cca4..6939eedb096 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -1,71 +1,44 @@ --- - name: ClangFormat Check - on: - push: - branches: - - main - - releasebranch_* - pull_request: - branches: - - main - - releasebranch_* - - "*" - concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: ${{ github.ref_protected != true }} - permissions: {} - jobs: - formatting-check: - name: Formatting Check - runs-on: ubuntu-latest - permissions: - pull-requests: write - steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 - with: - source: "." - clangFormatVersion: 15 - inplace: True - - name: Verify Changed files - uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 - id: verify-changed-files - - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - - name: List all changed files tracked and untracked files - run: | - echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" - - name: Add job summary without changed files - if: ${{ steps.verify-changed-files.outputs.files_changed == 'false' }} - run: | - { - echo "### Changed files:" - echo "No files were changed by clang-format" - } >> "$GITHUB_STEP_SUMMARY" - - name: Add job summary with changed files - if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} - run: | - { - echo '### Changed files:' - echo '```' - echo '${{ steps.verify-changed-files.outputs.changed_files }}' - echo '```' - } >> "$GITHUB_STEP_SUMMARY" - - name: 'Suggest' - uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 - with: - tool_name: clang-format - fail_on_error: true - # - uses: parkerbxyz/suggest-changes@f5b10bcbfe35840153c0e823095d260d5abad1f9 # v1.0.0 - # with: - # comment: | - # Please commit the suggested changes from clang-format. - - # Suggestions can only be added to lines near lines changed in this PR. - - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 - if: always() - with: - name: my-artifact - path: | - .clang-format - ${{ steps.verify-changed-files.outputs.changed_files }} - \ No newline at end of file +name: ClangFormat Check +on: + push: + branches: + - main + - releasebranch_* + pull_request: + branches: + - main + - releasebranch_* + - "*" +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: ${{ github.ref_protected != true }} +permissions: {} +jobs: + formatting-check: + name: Formatting Check + runs-on: ubuntu-latest + permissions: + contents: read + checks: write + issues: write + pull-requests: write + steps: + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 + with: + source: "." + clangFormatVersion: 15 + inplace: True + - name: Add code suggestions + uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 + with: + tool_name: clang-format + fail_on_error: true + - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 + if: always() + with: + name: my-artifact + path: | + .clang-format + ${{ steps.verify-changed-files.outputs.changed_files }} From a0ca9996a526bd10ef3ae5ad0874997d4c7776b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:10:12 +0000 Subject: [PATCH 06/34] Add a formatting errors in db.copy --- db/db.copy/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 5813cb18f35..dc9938fd9e4 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,10 +18,10 @@ #include #include -int main(int argc, char **argv) -{ +int main(int argc, char **argv) + { int ret; - struct Option *from_driver, *from_database, *from_table; + struct Option * from_driver, *from_database, *from_table; struct Option *to_driver, *to_database, *to_table; struct Option *where, *select; struct GModule *module; From f243cc2e926ffc31ef51abb98a31a9e4e9e3114e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Tue, 5 Mar 2024 23:12:18 -0500 Subject: [PATCH 07/34] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- db/db.copy/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index dc9938fd9e4..5813cb18f35 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,10 +18,10 @@ #include #include -int main(int argc, char **argv) - { +int main(int argc, char **argv) +{ int ret; - struct Option * from_driver, *from_database, *from_table; + struct Option *from_driver, *from_database, *from_table; struct Option *to_driver, *to_database, *to_table; struct Option *where, *select; struct GModule *module; From 59f4ebd37aa4f826aed37e8785530136f58dff63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:13:37 +0000 Subject: [PATCH 08/34] Change clang-format version to cause errors in unchanged files --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 6939eedb096..a80dd62b966 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -28,7 +28,7 @@ jobs: - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 with: source: "." - clangFormatVersion: 15 + clangFormatVersion: 16 inplace: True - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 From ebdec5e2d04d1bc47f2f6173e5e72b7a7b39e0a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:18:30 +0000 Subject: [PATCH 09/34] CI(clang-format): Add back verify-changed-files --- .github/workflows/clang-format-check.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index a80dd62b966..0afff01d706 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -30,6 +30,29 @@ jobs: source: "." clangFormatVersion: 16 inplace: True + - name: Verify Changed files + uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 + id: verify-changed-files + - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' + - name: List all changed files tracked and untracked files + run: | + echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + - name: Add job summary without changed files + if: ${{ steps.verify-changed-files.outputs.files_changed == 'false' }} + run: | + { + echo "### Changed files:" + echo "No files were changed by clang-format" + } >> "$GITHUB_STEP_SUMMARY" + - name: Add job summary with changed files + if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} + run: | + { + echo '### Changed files:' + echo '```' + echo '${{ steps.verify-changed-files.outputs.changed_files }}' + echo '```' + } >> "$GITHUB_STEP_SUMMARY" - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: From 17ff24d9c4ac884afcb41755abbe7a05f3f5423d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:18:50 +0000 Subject: [PATCH 10/34] CI(clang-format): Add step that fails if changed files --- .github/workflows/clang-format-check.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 0afff01d706..b90cd36105f 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -57,7 +57,7 @@ jobs: uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: tool_name: clang-format - fail_on_error: true + # fail_on_error: true - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: @@ -65,3 +65,6 @@ jobs: path: | .clang-format ${{ steps.verify-changed-files.outputs.changed_files }} + - name: Make job fail if changed files + if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} + run: exit 1 From 80cc35e160d531d449ffb92b133f7268cab2cb92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:19:38 +0000 Subject: [PATCH 11/34] Add a formatting errors in db.copy --- db/db.copy/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 5813cb18f35..bba32fe2c52 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,16 +18,16 @@ #include #include -int main(int argc, char **argv) -{ - int ret; - struct Option *from_driver, *from_database, *from_table; +int main(int argc, char **argv) +{ + int ret; + struct Option * from_driver, *from_database, *from_table; struct Option *to_driver, *to_database, *to_table; struct Option *where, *select; struct GModule *module; const char *drv, *db; - G_gisinit(argv[0]); + G_gisinit(argv[0]); /* Set description */ module = G_define_module(); @@ -56,7 +56,7 @@ int main(int argc, char **argv) from_table = G_define_standard_option(G_OPT_DB_TABLE); from_table->key = "from_table"; from_table->description = - _("Input table name (only, if 'select' is not used)"); + _("Input table name (only, if 'select' is not used)") ; to_driver = G_define_standard_option(G_OPT_DB_DRIVER); to_driver->key = "to_driver"; From 5896bc9649d103015b48846fad1a2a59deab128c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:24:12 +0000 Subject: [PATCH 12/34] CI(clang-format): Add text in job summary that more fixes need to be made for other files --- .github/workflows/clang-format-check.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index b90cd36105f..1038b622840 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -57,7 +57,8 @@ jobs: uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: tool_name: clang-format - # fail_on_error: true + fail_on_error: true + cleanup: false - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: @@ -67,4 +68,7 @@ jobs: ${{ steps.verify-changed-files.outputs.changed_files }} - name: Make job fail if changed files if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} - run: exit 1 + run: + echo '' >> "$GITHUB_STEP_SUMMARY" + echo 'More formatting errors on other files might need to be fixed manually' >> "$GITHUB_STEP_SUMMARY" + exit 1 From 5ec84d718f634c4abc614faf3f186c5601a5aaea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Tue, 5 Mar 2024 23:28:58 -0500 Subject: [PATCH 13/34] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- db/db.copy/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index bba32fe2c52..5813cb18f35 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,16 +18,16 @@ #include #include -int main(int argc, char **argv) -{ - int ret; - struct Option * from_driver, *from_database, *from_table; +int main(int argc, char **argv) +{ + int ret; + struct Option *from_driver, *from_database, *from_table; struct Option *to_driver, *to_database, *to_table; struct Option *where, *select; struct GModule *module; const char *drv, *db; - G_gisinit(argv[0]); + G_gisinit(argv[0]); /* Set description */ module = G_define_module(); @@ -56,7 +56,7 @@ int main(int argc, char **argv) from_table = G_define_standard_option(G_OPT_DB_TABLE); from_table->key = "from_table"; from_table->description = - _("Input table name (only, if 'select' is not used)") ; + _("Input table name (only, if 'select' is not used)"); to_driver = G_define_standard_option(G_OPT_DB_DRIVER); to_driver->key = "to_driver"; From b2d7e2209987d10110c0c64d3f7b8a65e5c812bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:26:38 +0000 Subject: [PATCH 14/34] CI(clang-format): Use "\n" as separator for file list --- .github/workflows/clang-format-check.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 1038b622840..d413f0627c3 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,6 +33,8 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files + with: + separator: "\n" - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | @@ -68,7 +70,6 @@ jobs: ${{ steps.verify-changed-files.outputs.changed_files }} - name: Make job fail if changed files if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} - run: - echo '' >> "$GITHUB_STEP_SUMMARY" + run: echo '' >> "$GITHUB_STEP_SUMMARY" echo 'More formatting errors on other files might need to be fixed manually' >> "$GITHUB_STEP_SUMMARY" exit 1 From 2e0e0b9bf68f64c641b72d5aadc2c509207d2911 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:33:39 +0000 Subject: [PATCH 15/34] CI(clang-format): Add text in job summary that more fixes need to be made for other files --- .github/workflows/clang-format-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index d413f0627c3..7e7a8712443 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -70,6 +70,7 @@ jobs: ${{ steps.verify-changed-files.outputs.changed_files }} - name: Make job fail if changed files if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} - run: echo '' >> "$GITHUB_STEP_SUMMARY" + run: | + echo '' >> "$GITHUB_STEP_SUMMARY" echo 'More formatting errors on other files might need to be fixed manually' >> "$GITHUB_STEP_SUMMARY" exit 1 From 3ef56900ea43ffd5990b63da608e7e658fbf6b72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:43:53 +0000 Subject: [PATCH 16/34] Revert: CI(clang-format): Use "\n" as separator for file list --- .github/workflows/clang-format-check.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 7e7a8712443..08114f038d0 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,8 +33,6 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files - with: - separator: "\n" - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | From 2969237d2f811d6163447ed55d6b786ebb4ac683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:44:22 +0000 Subject: [PATCH 17/34] Use bash loop to split list of files --- .github/workflows/clang-format-check.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 08114f038d0..323f8bdf98e 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -50,9 +50,14 @@ jobs: { echo '### Changed files:' echo '```' - echo '${{ steps.verify-changed-files.outputs.changed_files }}' + for i in $CHANGED_FILES + do + echo $i + done echo '```' } >> "$GITHUB_STEP_SUMMARY" + env: + CHANGED_FILES: ${{ steps.verify-changed-files.outputs.changed_files }} - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: From c6ad1e5098ceba05374872fdb67e1fe8205dfe1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:49:48 +0000 Subject: [PATCH 18/34] CI(clang-format): Use file filter mode for a second call --- .github/workflows/clang-format-check.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 323f8bdf98e..5f4e9248b2b 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -64,6 +64,13 @@ jobs: tool_name: clang-format fail_on_error: true cleanup: false + - name: Add file suggestions + uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 + with: + tool_name: clang-format + fail_on_error: true + filter_mode: file + cleanup: false - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From 3b0b606e7f217d95803ef3d48cafe05b72f6a6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:58:56 +0000 Subject: [PATCH 19/34] CI(clang-format): Add better text for job summary when changes remain and no suggestions were made --- .github/workflows/clang-format-check.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 5f4e9248b2b..726c0d826a6 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -78,9 +78,12 @@ jobs: path: | .clang-format ${{ steps.verify-changed-files.outputs.changed_files }} - - name: Make job fail if changed files + - name: Explain that more files need to be fixed if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | - echo '' >> "$GITHUB_STEP_SUMMARY" - echo 'More formatting errors on other files might need to be fixed manually' >> "$GITHUB_STEP_SUMMARY" + { + echo '' >> "$GITHUB_STEP_SUMMARY" + echo 'Suggestions can only be added near to lines changed in this PR.' + echo 'All the files above still need to be formatted, even without suggestions.' + } >> "$GITHUB_STEP_SUMMARY" exit 1 From 6af7e253b917a9f974b07a9bb0cf344be99bbb9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:00:15 +0000 Subject: [PATCH 20/34] Add a file with spaces in the name --- file with spaces.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 file with spaces.c diff --git a/file with spaces.c b/file with spaces.c new file mode 100644 index 00000000000..1991fd61f9e --- /dev/null +++ b/file with spaces.c @@ -0,0 +1,23 @@ +/**************************************************************************** + * + * MODULE: db.copy + * AUTHOR(S): Radim Blazek (original contributor) + * Glynn Clements , + * Markus Neteler + * PURPOSE: copy a table + * COPYRIGHT: (C) 2003-2006 by the GRASS Development Team + * + * This program is free software under the GNU General Public + * License (>=v2). Read the file COPYING that comes with GRASS + * for details. + * + *****************************************************************************/ + +#include + + +int main(int argc, char * * argv) +{ + int ret; + + } \ No newline at end of file From cb069a42e1610342c25eaa8c400feb7f65a389e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:05:09 +0000 Subject: [PATCH 21/34] CI(clang-format): Use "\n" as separator for file list --- .github/workflows/clang-format-check.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 726c0d826a6..ff1e84844d6 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,6 +33,8 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files + with: + separator: '\n' - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | From 6c454801784c5a690a045925b8070a7de0c699f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 00:11:49 -0500 Subject: [PATCH 22/34] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- file with spaces.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/file with spaces.c b/file with spaces.c index 1991fd61f9e..c6e030243e9 100644 --- a/file with spaces.c +++ b/file with spaces.c @@ -15,9 +15,7 @@ #include - -int main(int argc, char * * argv) +int main(int argc, char **argv) { - int ret; - - } \ No newline at end of file + int ret; +} \ No newline at end of file From 28681cd4ee217e2efafcb2ee29391dd509b90453 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:26:11 +0000 Subject: [PATCH 23/34] Add a file with special characters in the name --- file with special some%0Athing.c | 21 +++++++++++++++++++++ file with special some;thing.c | 21 +++++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 file with special some%0Athing.c create mode 100644 file with special some;thing.c diff --git a/file with special some%0Athing.c b/file with special some%0Athing.c new file mode 100644 index 00000000000..c6e030243e9 --- /dev/null +++ b/file with special some%0Athing.c @@ -0,0 +1,21 @@ +/**************************************************************************** + * + * MODULE: db.copy + * AUTHOR(S): Radim Blazek (original contributor) + * Glynn Clements , + * Markus Neteler + * PURPOSE: copy a table + * COPYRIGHT: (C) 2003-2006 by the GRASS Development Team + * + * This program is free software under the GNU General Public + * License (>=v2). Read the file COPYING that comes with GRASS + * for details. + * + *****************************************************************************/ + +#include + +int main(int argc, char **argv) +{ + int ret; +} \ No newline at end of file diff --git a/file with special some;thing.c b/file with special some;thing.c new file mode 100644 index 00000000000..c6e030243e9 --- /dev/null +++ b/file with special some;thing.c @@ -0,0 +1,21 @@ +/**************************************************************************** + * + * MODULE: db.copy + * AUTHOR(S): Radim Blazek (original contributor) + * Glynn Clements , + * Markus Neteler + * PURPOSE: copy a table + * COPYRIGHT: (C) 2003-2006 by the GRASS Development Team + * + * This program is free software under the GNU General Public + * License (>=v2). Read the file COPYING that comes with GRASS + * for details. + * + *****************************************************************************/ + +#include + +int main(int argc, char **argv) +{ + int ret; +} \ No newline at end of file From 50587c5e040a33670791192b9505707fb46cafc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:26:33 +0000 Subject: [PATCH 24/34] Use git ls-files to set a file list --- .github/workflows/clang-format-check.yml | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index ff1e84844d6..a24e1f71822 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,9 +33,20 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files - with: - separator: '\n' + - id: git-changed-files + run: | + { + echo 'CHANGED_FILES<> "$GITHUB_ENV" + { + echo 'CHANGED_FILES<> "$GITHUB_OUTPUT" - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' + - run: echo '${{toJson(steps.git-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" @@ -52,14 +63,9 @@ jobs: { echo '### Changed files:' echo '```' - for i in $CHANGED_FILES - do - echo $i - done + git ls-files --other --modified --exclude-standard echo '```' } >> "$GITHUB_STEP_SUMMARY" - env: - CHANGED_FILES: ${{ steps.verify-changed-files.outputs.changed_files }} - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: From 927c82d8cde6127dead819dbf578fe04e612e6fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:29:42 +0000 Subject: [PATCH 25/34] CI(clang-format): Upload artifacts of changed files from git ls-files output --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index a24e1f71822..9cda0dbba5e 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -85,7 +85,7 @@ jobs: name: my-artifact path: | .clang-format - ${{ steps.verify-changed-files.outputs.changed_files }} + ${{ steps.git-changed-files.outputs.CHANGED_FILES }} - name: Explain that more files need to be fixed if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | From 53344463c48b80549cfc9f4a74a3f484c763f61b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:33:40 +0000 Subject: [PATCH 26/34] CI(clang-format): Upload artifacts of changed files from git ls-files output after message of other files --- .github/workflows/clang-format-check.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 9cda0dbba5e..b4f639fa4a5 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -79,13 +79,7 @@ jobs: fail_on_error: true filter_mode: file cleanup: false - - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 - if: always() - with: - name: my-artifact - path: | - .clang-format - ${{ steps.git-changed-files.outputs.CHANGED_FILES }} + - name: Explain that more files need to be fixed if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | @@ -95,3 +89,10 @@ jobs: echo 'All the files above still need to be formatted, even without suggestions.' } >> "$GITHUB_STEP_SUMMARY" exit 1 + - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 + if: always() + with: + name: my-artifact + path: | + .clang-format + ${{ steps.git-changed-files.outputs.CHANGED_FILES }} From 237f2623335da067dd92f976e699377790038dfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:34:09 +0000 Subject: [PATCH 27/34] Add broken files --- file with spaces.c | 7 ++++--- file with special some%0Athing.c | 9 +++++---- file with special some;thing.c | 4 ++-- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/file with spaces.c b/file with spaces.c index c6e030243e9..b5be9fe21d6 100644 --- a/file with spaces.c +++ b/file with spaces.c @@ -13,9 +13,10 @@ * *****************************************************************************/ -#include +#include -int main(int argc, char **argv) +int main(int argc, char * * argv) { + int ret; -} \ No newline at end of file + } \ No newline at end of file diff --git a/file with special some%0Athing.c b/file with special some%0Athing.c index c6e030243e9..768e898d386 100644 --- a/file with special some%0Athing.c +++ b/file with special some%0Athing.c @@ -15,7 +15,8 @@ #include -int main(int argc, char **argv) -{ - int ret; -} \ No newline at end of file +int main(int +argc , char **argv) + { + int ret ; + } \ No newline at end of file diff --git a/file with special some;thing.c b/file with special some;thing.c index c6e030243e9..54af84aea11 100644 --- a/file with special some;thing.c +++ b/file with special some;thing.c @@ -15,7 +15,7 @@ #include -int main(int argc, char **argv) +int main( int argc, char **argv) { - int ret; + int ret; } \ No newline at end of file From 78bbf38eb27f1e20a578916376f647fe10870b94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:47:52 +0000 Subject: [PATCH 28/34] CI(clang-format): Remove unneeded steps --- .github/workflows/clang-format-check.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index b4f639fa4a5..305315c2aec 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -35,18 +35,11 @@ jobs: id: verify-changed-files - id: git-changed-files run: | - { - echo 'CHANGED_FILES<> "$GITHUB_ENV" { echo 'CHANGED_FILES<> "$GITHUB_OUTPUT" - - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - - run: echo '${{toJson(steps.git-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" @@ -79,14 +72,15 @@ jobs: fail_on_error: true filter_mode: file cleanup: false - - name: Explain that more files need to be fixed if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | { echo '' >> "$GITHUB_STEP_SUMMARY" echo 'Suggestions can only be added near to lines changed in this PR.' - echo 'All the files above still need to be formatted, even without suggestions.' + echo 'All these fixed files are included in the artifact.' + echo 'The artifact can be downloaded and copied to the the repository' + echo 'to replace unformatted files with the formatted files.' } >> "$GITHUB_STEP_SUMMARY" exit 1 - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 From 92957ada7ca8412afcf51d5f6e2a918ee98120ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:48:33 +0000 Subject: [PATCH 29/34] Revert "Add broken files" This reverts commit 237f2623335da067dd92f976e699377790038dfd. --- file with spaces.c | 7 +++---- file with special some%0Athing.c | 9 ++++----- file with special some;thing.c | 4 ++-- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/file with spaces.c b/file with spaces.c index b5be9fe21d6..c6e030243e9 100644 --- a/file with spaces.c +++ b/file with spaces.c @@ -13,10 +13,9 @@ * *****************************************************************************/ -#include +#include -int main(int argc, char * * argv) +int main(int argc, char **argv) { - int ret; - } \ No newline at end of file +} \ No newline at end of file diff --git a/file with special some%0Athing.c b/file with special some%0Athing.c index 768e898d386..c6e030243e9 100644 --- a/file with special some%0Athing.c +++ b/file with special some%0Athing.c @@ -15,8 +15,7 @@ #include -int main(int -argc , char **argv) - { - int ret ; - } \ No newline at end of file +int main(int argc, char **argv) +{ + int ret; +} \ No newline at end of file diff --git a/file with special some;thing.c b/file with special some;thing.c index 54af84aea11..c6e030243e9 100644 --- a/file with special some;thing.c +++ b/file with special some;thing.c @@ -15,7 +15,7 @@ #include -int main( int argc, char **argv) +int main(int argc, char **argv) { - int ret; + int ret; } \ No newline at end of file From fc74626f914da1904e92992bca907322862a94c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:51:53 +0000 Subject: [PATCH 30/34] CI(clang-format): Remove file suggestions --- .github/workflows/clang-format-check.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 305315c2aec..f3c4d241687 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -65,13 +65,6 @@ jobs: tool_name: clang-format fail_on_error: true cleanup: false - - name: Add file suggestions - uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 - with: - tool_name: clang-format - fail_on_error: true - filter_mode: file - cleanup: false - name: Explain that more files need to be fixed if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | From d606f676997e67710ee6c1edc0b91f25baccde02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:52:36 +0000 Subject: [PATCH 31/34] CI(clang-format): Edit text in job summary --- .github/workflows/clang-format-check.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index f3c4d241687..90b92cd636e 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -69,11 +69,9 @@ jobs: if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | { - echo '' >> "$GITHUB_STEP_SUMMARY" + echo '' echo 'Suggestions can only be added near to lines changed in this PR.' - echo 'All these fixed files are included in the artifact.' - echo 'The artifact can be downloaded and copied to the the repository' - echo 'to replace unformatted files with the formatted files.' + echo 'All these fixed files are included in the artifact. The artifact can be downloaded and copied to the the repository to replace unformatted files with the formatted files.' } >> "$GITHUB_STEP_SUMMARY" exit 1 - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 From c1f31c28a9a49c7f9f2ef6ca6e5655be9333059f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 05:59:44 +0000 Subject: [PATCH 32/34] CI(clang-format): Fill file list from env var --- .github/workflows/clang-format-check.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 90b92cd636e..c745bf983ca 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -42,7 +42,7 @@ jobs: } >> "$GITHUB_OUTPUT" - name: List all changed files tracked and untracked files run: | - echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + echo "Changed files: ${{ steps.git-changed-files.outputs.CHANGED_FILES }}" - name: Add job summary without changed files if: ${{ steps.verify-changed-files.outputs.files_changed == 'false' }} run: | @@ -56,9 +56,11 @@ jobs: { echo '### Changed files:' echo '```' - git ls-files --other --modified --exclude-standard + echo "${CHANGED_FILES}" echo '```' } >> "$GITHUB_STEP_SUMMARY" + env: + CHANGED_FILES: ${{ steps.git-changed-files.outputs.CHANGED_FILES }} - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: From fd9897a0d668cad4ab189c98d18ecdae107f447f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 06:09:13 +0000 Subject: [PATCH 33/34] Add error in db.copy --- db/db.copy/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 5813cb18f35..bd8f80e7a2d 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,13 +18,13 @@ #include #include -int main(int argc, char **argv) -{ +int main(int argc, char * *argv) + { int ret; struct Option *from_driver, *from_database, *from_table; struct Option *to_driver, *to_database, *to_table; - struct Option *where, *select; - struct GModule *module; + struct Option * where, *select; + struct GModule * module ; const char *drv, *db; G_gisinit(argv[0]); From 30e311155b7c4c90b65a6b29faf8ff1ede879f07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 06:10:35 +0000 Subject: [PATCH 34/34] CI(clang-format): Re-use version 15 of clang-format --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index c745bf983ca..5fe6cac3375 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -28,7 +28,7 @@ jobs: - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 with: source: "." - clangFormatVersion: 16 + clangFormatVersion: 15 inplace: True - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0