-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert che-server workspaces into devworkspaces #441
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 50.32% 50.57% +0.24%
==========================================
Files 220 222 +2
Lines 7614 7803 +189
Branches 1272 1310 +38
==========================================
+ Hits 3832 3946 +114
- Misses 3415 3480 +65
- Partials 367 377 +10
Continue to review full report at Codecov.
|
8e5fd44
to
7d2a38c
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441 |
e767018
to
b77a8e6
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441 |
@akurinnoy I have tested this PR and have 8 samples with errors. Workspace conversion failed:
Failed status after conversion:
|
Added area-label to get rid of hundreds warning in browser console.
get rid of unnecessary patch request
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441 |
@ibuziuk I've opened an issue for decreasing the conversion time eclipse-che/che#21092 |
What does this PR do?
With
devworkspaces.enabled: 'true'
, the dashboard :The conversion means that the old workspace devfile v1 is converted into devfile v2 and the new devfile is used to create a new devworkspace. When the conversion is done, the old workspace gets hidden from the workspaces list. In case it's necessary users still can view the old devfile.
What issues does this PR fix or reference?
eclipse-che/che#20845
Is it tested? How?
Release Notes
Docs PR