Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert che-server workspaces into devworkspaces #441

Merged
merged 20 commits into from
Jan 31, 2022
Merged

Convert che-server workspaces into devworkspaces #441

merged 20 commits into from
Jan 31, 2022

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

With devworkspaces.enabled: 'true', the dashboard :

  • shows che-server workspaces as deprecated
  • hides them from recent workspacspaces list
  • don't allow to start/edit old workspaces
  • and adds the ability to convert them into devworkspaces.

The conversion means that the old workspace devfile v1 is converted into devfile v2 and the new devfile is used to create a new devworkspace. When the conversion is done, the old workspace gets hidden from the workspaces list. In case it's necessary users still can view the old devfile.

What issues does this PR fix or reference?

eclipse-che/che#20845

Is it tested? How?

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #441 (afaaac0) into main (38cc6b7) will increase coverage by 0.24%.
The diff coverage is 62.22%.

❗ Current head afaaac0 differs from pull request most recent head 1651f28. Consider uploading reports for the commit 1651f28 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   50.32%   50.57%   +0.24%     
==========================================
  Files         220      222       +2     
  Lines        7614     7803     +189     
  Branches     1272     1310      +38     
==========================================
+ Hits         3832     3946     +114     
- Misses       3415     3480      +65     
- Partials      367      377      +10     
Impacted Files Coverage Δ
...dashboard-frontend/src/Layout/Navigation/index.tsx 0.00% <ø> (ø)
...dashboard-frontend/src/components/Header/index.tsx 100.00% <ø> (ø)
...board-frontend/src/containers/WorkspaceDetails.tsx 0.00% <0.00%> (ø)
...ontend/src/pages/WorkspaceDetails/Header/index.tsx 0.00% <ø> (ø)
...d/src/pages/WorkspaceDetails/OverviewTab/index.tsx 0.00% <0.00%> (ø)
...oard-frontend/src/pages/WorkspaceDetails/index.tsx 0.00% <0.00%> (ø)
...dashboard-frontend/src/services/bootstrap/index.ts 0.00% <0.00%> (ø)
...s/dashboard-frontend/src/services/helpers/types.ts 100.00% <ø> (ø)
...ontend/src/store/Workspaces/devWorkspaces/index.ts 8.04% <0.00%> (-0.29%) ⬇️
...s/dashboard-frontend/src/store/Workspaces/index.ts 7.14% <0.00%> (-0.12%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cc6b7...1651f28. Read the comment docs.

@akurinnoy akurinnoy force-pushed the che-20845 branch 2 times, most recently from 8e5fd44 to 7d2a38c Compare January 19, 2022 14:34
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 19, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 19, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 19, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 19, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 19, 2022
@akurinnoy akurinnoy marked this pull request as ready for review January 20, 2022 12:04
@akurinnoy akurinnoy requested a review from olexii4 as a code owner January 20, 2022 12:04
@akurinnoy akurinnoy requested a review from ibuziuk January 20, 2022 12:04
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 20, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 20, 2022
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441

@akurinnoy akurinnoy force-pushed the che-20845 branch 2 times, most recently from e767018 to b77a8e6 Compare January 25, 2022 08:58
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441

@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 25, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 25, 2022
@eclipse-che eclipse-che deleted a comment from github-actions bot Jan 25, 2022
@olexii4
Copy link
Contributor

olexii4 commented Jan 26, 2022

@akurinnoy I have tested this PR and have 8 samples with errors.

Workspace conversion failed:

  • apache-camel-k
screenshot

2022-01-26__11_22_50

  • che4z
screenshot

2022-01-26_11_30_04

  • rust
screenshot

2022-01-26__11_33_54

Failed status after conversion:

  • scala-sbt
screenshot

2022-01-26__11_01_16

  • quarkus
screenshot

2022-01-26__11_08_07

  • java-gradle
screenshot

2022-01-26__11_12_15

  • dotnet
screenshot

2022-01-26__11_17_36

  • asp.net
screenshot

2022-01-26__11_20_29

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-441

@akurinnoy
Copy link
Contributor Author

@ibuziuk I've opened an issue for decreasing the conversion time eclipse-che/che#21092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants