Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when passing the editor's Devfile link #751

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Mar 7, 2023

What does this PR do?

Fix an error when passing the editor's Devfile link.

What issues does this PR fix or reference?

fixes eclipse-che/che#22041
fixes eclipse-che/che#22061

@olexii4 olexii4 requested a review from ibuziuk March 7, 2023 14:08
@olexii4 olexii4 requested a review from akurinnoy as a code owner March 7, 2023 14:08
@che-bot
Copy link
Contributor

che-bot commented Mar 7, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Mar 7, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 7, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 would be really nice to add more tests for covering this case

@che-bot
Copy link
Contributor

che-bot commented Mar 15, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #751 (635678e) into main (29164d1) will decrease coverage by 0.07%.
The diff coverage is 61.11%.

❗ Current head 635678e differs from pull request most recent head 39cfc27. Consider uploading reports for the commit 39cfc27 to get more accurate results

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   77.67%   77.60%   -0.07%     
==========================================
  Files         317      318       +1     
  Lines       31276    31363      +87     
  Branches     1867     1878      +11     
==========================================
+ Hits        24294    24340      +46     
- Misses       6931     6971      +40     
- Partials       51       52       +1     
Flag Coverage Δ
unittests 77.60% <61.11%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board-frontend/src/store/ServerConfig/selectors.ts 93.18% <0.00%> (-2.28%) ⬇️
.../src/routes/api/helpers/getCertificateAuthority.ts 42.66% <17.94%> (-24.00%) ⬇️
...ontend/src/store/Workspaces/devWorkspaces/index.ts 80.58% <60.46%> (-0.81%) ⬇️
...s/dashboard-frontend/src/store/Workspaces/index.ts 58.04% <66.66%> (+0.13%) ⬆️
...-frontend/src/services/workspace-client/helpers.ts 87.57% <83.33%> (-1.32%) ⬇️
...end/src/store/DevfileRegistries/getDevfileByUrl.ts 93.47% <93.47%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2023

Click here to review and test in web IDE: Contribute

3 similar comments
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@che-bot
Copy link
Contributor

che-bot commented Mar 20, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Mar 20, 2023

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path a94e82a link true /test v11-dashboard-happy-path
ci/prow/v11-images a94e82a link true /test v11-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751

@olexii4 olexii4 merged commit b229ff4 into main Mar 20, 2023
@olexii4 olexii4 deleted the CHE-22041 branch March 20, 2023 12:56
ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
* fix: an error when passing the editor's devfile link

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants