-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error when passing the editor's Devfile link #751
Conversation
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 would be really nice to add more tests for covering this case
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
Codecov Report
@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 77.67% 77.60% -0.07%
==========================================
Files 317 318 +1
Lines 31276 31363 +87
Branches 1867 1878 +11
==========================================
+ Hits 24294 24340 +46
- Misses 6931 6971 +40
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
3 similar comments
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
@olexii4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-751 |
* fix: an error when passing the editor's devfile link Signed-off-by: Oleksii Orel <oorel@redhat.com>
What does this PR do?
Fix an error when passing the editor's Devfile link.
What issues does this PR fix or reference?
fixes eclipse-che/che#22041
fixes eclipse-che/che#22061