Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the warning when trying to start an empty workspace #768

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 6, 2023

What does this PR do?

Fixed the warning when trying to start an empty workspace.

What issues does this PR fix or reference?

fixes eclipse-che/che#22057

@olexii4 olexii4 requested a review from ibuziuk April 6, 2023 13:28
@olexii4 olexii4 requested a review from akurinnoy as a code owner April 6, 2023 13:28
@che-bot
Copy link
Contributor

che-bot commented Apr 6, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Apr 6, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-768

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-768

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #768 (045ad16) into main (cf4ae01) will increase coverage by 0.01%.
The diff coverage is 82.14%.

❗ Current head 045ad16 differs from pull request most recent head 2cba2c4. Consider uploading reports for the commit 2cba2c4 to get more accurate results

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   77.81%   77.83%   +0.01%     
==========================================
  Files         319      320       +1     
  Lines       31561    31570       +9     
  Branches     1904     1903       -1     
==========================================
+ Hits        24559    24571      +12     
+ Misses       6949     6946       -3     
  Partials       53       53              
Flag Coverage Δ
unittests 77.83% <82.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard-frontend/src/services/devfile/adapter.ts 52.57% <55.55%> (+5.35%) ⬆️
.../dashboard-frontend/src/services/devfile/helper.ts 81.25% <81.25%> (ø)
...ader/Factory/Steps/Apply/Devfile/prepareDevfile.ts 93.93% <100.00%> (-3.50%) ⬇️
...nd/src/store/FactoryResolver/normalizeDevfileV2.ts 70.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci openshift-ci bot removed the lgtm label Apr 7, 2023
@che-bot
Copy link
Contributor

che-bot commented Apr 7, 2023

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 2cba2c4 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-768

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit a22a8ea into main Apr 7, 2023
@olexii4 olexii4 deleted the CHE-22057 branch April 7, 2023 13:55
@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/232: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/2718: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/232: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2955 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: copyIIBsToQuay/1212: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: sync-to-downstream_3.x/2957: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2767 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.7 :: operator-bundle_3.x/1100: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2957 triggered

@devstudio-release
Copy link

Build 3.7 :: dsc_3.x/772: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: dsc_3.x/772: SUCCESS

3.7.0 CI

@devstudio-release
Copy link

Build 3.7 :: copyIIBsToQuay/1212: SUCCESS

3.7
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.7-5
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-473600-440885-ppc64le
  + quay.io/devspaces/iib:3.7-v4.12-473599-440880-ppc64le
  + quay.io/devspaces/iib:3.7-v4.11-473616-440871-ppc64le
  + quay.io/devspaces/iib:3.7-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.7-v4.10-473615-440866-ppc64le
  + quay.io/devspaces/iib:3.7-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-473600-440885-x86_64
  + quay.io/devspaces/iib:3.7-v4.12-473599-440880-x86_64
  + quay.io/devspaces/iib:3.7-v4.11-473616-440871-x86_64
  + quay.io/devspaces/iib:3.7-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.7-v4.10-473615-440866-x86_64
  + quay.io/devspaces/iib:3.7-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-473600-440885-s390x
  + quay.io/devspaces/iib:3.7-v4.12-473621-440880-s390x
  + quay.io/devspaces/iib:3.7-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.7-v4.11-473616-440871-s390x
  + quay.io/devspaces/iib:3.7-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.7-v4.10-473615-440866-s390x
  + quay.io/devspaces/iib:3.7-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x

ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
…#768)

* fix: warning when tries to start an empty workspace

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard prints warning when tries to start an empty workspace
5 participants