Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from Monaco to CodeMirror #945

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat: migrate from Monaco to CodeMirror #945

merged 3 commits into from
Oct 10, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 9, 2023

What does this PR do?

Migrate from Monaco to CodeMirror.

What issues does this PR fix or reference?

fixes eclipse-che/che#22481, eclipse-che/che#22237

Is it tested? How?

Before migration:
Знімок екрана 2023-10-09 о 12 30 08

After migration:
Знімок екрана 2023-10-09 о 12 15 22

Знімок екрана 2023-10-09 о 06 38 21
Знімок екрана 2023-10-09 о 06 38 29

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 9, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #945 (8965ab5) into main (e12182d) will increase coverage by 0.48%.
Report is 2 commits behind head on main.
The diff coverage is 44.82%.

❗ Current head 8965ab5 differs from pull request most recent head 9c917cb. Consider uploading reports for the commit 9c917cb to get more accurate results

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   82.30%   82.78%   +0.48%     
==========================================
  Files         364      360       -4     
  Lines       38046    36923    -1123     
  Branches     2450     2386      -64     
==========================================
- Hits        31314    30567     -747     
+ Misses       6706     6329     -377     
- Partials       26       27       +1     
Flag Coverage Δ
unittests 82.78% <44.82%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/dashboard-backend/src/app.ts 93.10% <ø> (-0.18%) ⬇️
...ages/dashboard-backend/src/plugins/staticServer.ts 93.18% <ø> (-0.16%) ⬇️
.../dashboard-frontend/src/services/helpers/editor.ts 81.35% <ø> (-14.71%) ⬇️
...oard-frontend/src/store/DevfileRegistries/index.ts 78.66% <ø> (+1.25%) ⬆️
...dashboard-frontend/src/services/bootstrap/index.ts 0.00% <0.00%> (ø)
...oard-frontend/src/pages/WorkspaceDetails/index.tsx 69.07% <33.33%> (-16.60%) ⬇️
...s/WorkspaceDetails/DevworkspaceEditorTab/index.tsx 0.00% <0.00%> (ø)
.../pages/WorkspaceDetails/DevfileEditorTab/index.tsx 50.56% <35.71%> (-20.17%) ⬇️
...rd-frontend/src/components/DevfileViewer/index.tsx 54.66% <54.66%> (ø)

... and 4 files with indirect coverage changes

@ibuziuk
Copy link
Member

ibuziuk commented Oct 9, 2023

@olexii4 LGTM, could you clarify how the devfile schema is going to be validated now? Asking in the context of eclipse-che/che#21845 ?

@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2023
@olexii4
Copy link
Contributor Author

olexii4 commented Oct 9, 2023

@olexii4 LGTM, could you clarify how the devfile schema is going to be validated now? Asking in the context of eclipse/che#21845 ?

@ibuziuk It is still validating on che-server side during factory resolving.
Now we don't have the ability to change a devfile from the dashboard client side. This schema API became useless.

Previously we used to use these schemas to validate a devfile with the editor language server when we tried to change a devfile.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945

@ibuziuk ibuziuk requested a review from vinokurig October 9, 2023 13:41
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 9c917cb link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vinokurig
Copy link
Contributor

@ibuziuk It is still validating on che-server side during factory resolving.
Now we don't have the ability to change a devfile from the dashboard client side. This schema API became useless.

Previously we used to use these schemas to validate a devfile with the editor language server when we tried to change a devfile.

If we are going to return back the devfile validation mechanism to the dashboard side, I am +1 to remove the validation check from the che-server side.

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 7486131 into main Oct 10, 2023
10 checks passed
@olexii4 olexii4 deleted the CHE-22481 branch October 10, 2023 09:49
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/362: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/362: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4918 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1991: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4919: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4741 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2142: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4919 triggered

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4572: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2142 triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Migrating from Monaco Editor to CodeMirror
6 participants