-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate from Monaco to CodeMirror #945
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945 |
Codecov Report
@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 82.30% 82.78% +0.48%
==========================================
Files 364 360 -4
Lines 38046 36923 -1123
Branches 2450 2386 -64
==========================================
- Hits 31314 30567 -747
+ Misses 6706 6329 -377
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@olexii4 LGTM, could you clarify how the devfile schema is going to be validated now? Asking in the context of eclipse-che/che#21845 ? |
@ibuziuk It is still validating on Previously we used to use these schemas to validate a devfile with the editor language server when we tried to change a devfile. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-945 |
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
If we are going to return back the devfile validation mechanism to the dashboard side, I am +1 to remove the validation check from the che-server side. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: dashboard_3.x/362: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4918: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3475: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4740: dashboard : 3.x :: Build 56083484 : quay.io/devspaces/dashboard-rhel8:3.10-36 |
Build 3.10 :: update-digests_3.x/4572: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/362: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4918 triggered |
Build 3.10 :: operator-bundle_3.x/2142: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4919: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3476: Console, Changes, Git Data |
Build 3.10 :: copyIIBsToQuay/1991: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4919: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4741 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.10 :: operator-bundle_3.x/2142: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4919 triggered |
Build 3.10 :: update-digests_3.x/4572: Detected new images: rebuild operator-bundle |
What does this PR do?
Migrate from Monaco to CodeMirror.
What issues does this PR fix or reference?
fixes eclipse-che/che#22481, eclipse-che/che#22237
Is it tested? How?
Before migration:
After migration: