This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: introduce devfile v2 for Apache Camel-k #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I50035d90f917bde31d92cd27ce9f9042103be498 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
svor
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
I see an error in Camel K output window but the plugin was initialized
Found Kubernetes CLI (kubectl) version 1.23...
No version found. Using default version 1.5.0 of Apache Camel K CLI
error: the server doesn't have a resource type "integrations"
I'm not familiar with Apache Camel K tools, so can't say if it's a big problem or not.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add camel-k examples
There is an issue for Apache Camel Language Server but it's not related to the devfile itself
Issue found:
camel-tooling/camel-lsp-client-vscode#836
PR to fix:
camel-tooling/camel-lsp-client-vscode#837
Screenshot/screencast of this PR
What issues does this PR fix or reference?
part of eclipse-che/che#19341
How to test this PR?
Click on
https://che-server#https://github.com/che-samples/apache-camel-k/tree/devfilev2Go to the View/Output and check Apache Camel-k output
you should see that camel-k binary has been found on the filesystem.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: I50035d90f917bde31d92cd27ce9f9042103be498
Signed-off-by: Florent Benoit fbenoit@redhat.com